-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Move repository sub menu data loading to the shared file and only display license on repository home page #32686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4db395f
Move licenses renders to shared file to avoid unnecesary loading
lunny d61ac5d
Rename functions and add some comments
lunny 3623a5c
fix comments
lunny 51f4ad8
Only display license on repository home page
lunny 48731d4
Move all logic to prepare sub menu data
lunny 52bd341
Merge branch 'main' into lunny/move_license_sub_menu
lunny ffc5b6c
Move branch number to sub menu shared file
lunny File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| // Copyright 2024 The Gitea Authors. All rights reserved. | ||
| // SPDX-License-Identifier: MIT | ||
|
|
||
| package shared | ||
|
|
||
| import ( | ||
| "code.gitea.io/gitea/models/db" | ||
| git_model "code.gitea.io/gitea/models/git" | ||
| repo_model "code.gitea.io/gitea/models/repo" | ||
| "code.gitea.io/gitea/modules/cache" | ||
| "code.gitea.io/gitea/modules/git" | ||
| "code.gitea.io/gitea/modules/optional" | ||
| repo_module "code.gitea.io/gitea/modules/repository" | ||
| "code.gitea.io/gitea/services/context" | ||
| repo_service "code.gitea.io/gitea/services/repository" | ||
| ) | ||
|
|
||
| // PrepareRepoSubMenu prepares data for repository template repo/sub_menu.tmpl | ||
| func PrepareRepoSubMenu(ctx *context.Context) bool { | ||
| if !prepareSubmenuBranch(ctx) { | ||
| return false | ||
| } | ||
|
|
||
| if !PrepareSubmenuTag(ctx) { | ||
| return false | ||
| } | ||
|
|
||
| if !prepareSubmenuCommit(ctx) { | ||
| return false | ||
| } | ||
|
|
||
| // only show license on repository's home page | ||
| if ctx.Data["PageIsRepoHome"] == true { | ||
| if !prepareSubmenuLicense(ctx) { | ||
| return false | ||
| } | ||
| } | ||
|
|
||
| return true | ||
| } | ||
|
|
||
| func prepareSubmenuLicense(ctx *context.Context) bool { | ||
| repoLicenses, err := repo_model.GetRepoLicenses(ctx, ctx.Repo.Repository) | ||
| if err != nil { | ||
| ctx.ServerError("GetRepoLicenses", err) | ||
| return false | ||
| } | ||
| ctx.Data["DetectedRepoLicenses"] = repoLicenses.StringList() | ||
| ctx.Data["LicenseFileName"] = repo_service.LicenseFileName | ||
| return true | ||
| } | ||
|
|
||
| func prepareSubmenuBranch(ctx *context.Context) bool { | ||
| branchOpts := git_model.FindBranchOptions{ | ||
| RepoID: ctx.Repo.Repository.ID, | ||
| IsDeletedBranch: optional.Some(false), | ||
| ListOptions: db.ListOptionsAll, | ||
| } | ||
| branchesTotal, err := db.Count[git_model.Branch](ctx, branchOpts) | ||
| if err != nil { | ||
| ctx.ServerError("CountBranches", err) | ||
| return false | ||
| } | ||
|
|
||
| // non-empty repo should have at least 1 branch, so this repository's branches haven't been synced yet | ||
| if branchesTotal == 0 { // fallback to do a sync immediately | ||
| branchesTotal, err = repo_module.SyncRepoBranches(ctx, ctx.Repo.Repository.ID, 0) | ||
| if err != nil { | ||
| ctx.ServerError("SyncRepoBranches", err) | ||
| return false | ||
| } | ||
| } | ||
|
|
||
| ctx.Data["BranchesCount"] = branchesTotal | ||
| return true | ||
| } | ||
|
|
||
| func PrepareSubmenuTag(ctx *context.Context) bool { | ||
| var err error | ||
| ctx.Data["NumTags"], err = db.Count[repo_model.Release](ctx, repo_model.FindReleasesOptions{ | ||
| IncludeDrafts: true, | ||
| IncludeTags: true, | ||
| HasSha1: optional.Some(true), // only draft releases which are created with existing tags | ||
| RepoID: ctx.Repo.Repository.ID, | ||
| }) | ||
| if err != nil { | ||
| ctx.ServerError("GetReleaseCountByRepoID", err) | ||
| return false | ||
| } | ||
| return true | ||
| } | ||
|
|
||
| func prepareSubmenuCommit(ctx *context.Context) bool { | ||
| var err error | ||
| ctx.Repo.CommitsCount, err = ctx.Repo.GetCommitsCount() | ||
| if err != nil { | ||
| ctx.ServerError("GetCommitsCount", err) | ||
| return false | ||
| } | ||
| ctx.Data["CommitsCount"] = ctx.Repo.CommitsCount | ||
| ctx.Repo.GitRepo.LastCommitCache = git.NewLastCommitCache(ctx.Repo.CommitsCount, ctx.Repo.Repository.FullName(), ctx.Repo.GitRepo, cache.GetCache()) | ||
| return true | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.