Prevent creating empy PR (w/o commits) through API

[siccous]

Check number of commits between head and base during PR creation, if not greater than zero return error.

[wxiaoguang]

Check number of commits between head and base during PR creation, if not greater than zero return error.

Well, I know some users ever requested to "allow to create empty PR" because they need an empty PR to start their work (different teams have different workflows)

So, I guess it won't hurt without such check? 🤔

[siccous]

Understand, it hits me because it is different from GitHub API behaviour.

Details in my issue #32743.

[wxiaoguang]

Understand, it hits me because it is different from GitHub API behaviour.

A lot of Gitea's behaviors are different from GitHub, actually there is no compatibility guaranteed, Gitea is an independent project.

And you see, the CI tests fail 😅

[lunny]

It's useful to create an empty pull request especially for #31899

[yp05327]

Actually, IMO it is a feature in Gitea which is different from GitHub.
And you can also create empty PR from Web UI. So the behavior should be same between them at least.

[siccous]

Okey, is there any interest to make it configurable as an argument in the create PR API call? If not, then feel free to close this PR.

Thank you all.

[wxiaoguang]

is there any interest to make it configurable as an argument in the create PR API call?

I think it is feasible if there are tests to cover it.

[wxiaoguang]

Inactive for long time, feel free to reopen if there would be new progress.