Skip to content

Refactor markdown math render, add dollor-backquote syntax support #32831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 14, 2024
Merged

Refactor markdown math render, add dollor-backquote syntax support #32831

merged 7 commits into from
Dec 14, 2024

Conversation

@wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Dec 13, 2024

Add more tests

@wxiaoguang wxiaoguang added this to the 1.23.0 milestone Dec 13, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 13, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Dec 13, 2024
@wxiaoguang wxiaoguang mentioned this pull request Dec 13, 2024
Closed
@wxiaoguang wxiaoguang force-pushed the fix-math branch 2 times, most recently from b509f95 to c2b67b3 Compare December 13, 2024 13:52
@wxiaoguang wxiaoguang mentioned this pull request Dec 13, 2024
Closed
@wxiaoguang wxiaoguang force-pushed the fix-math branch 3 times, most recently from b5b4d3b to 7b19488 Compare December 13, 2024 22:11
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 14, 2024
silverwind
silverwind reviewed Dec 14, 2024
View reviewed changes
wxiaoguang
wxiaoguang commented Dec 14, 2024
View reviewed changes
@silverwind
Copy link
Member

silverwind commented Dec 14, 2024 •
edited
Loading

BTW I would prefer to move the display class to a data-display attribute but that would require changes to the markup sanitizer, so not so simple.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 14, 2024
@wxiaoguang wxiaoguang merged commit cc5ff98 into go-gitea:main Dec 14, 2024
26 checks passed
@wxiaoguang wxiaoguang deleted the fix-math branch December 14, 2024 05:43
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Dec 14, 2024

BTW I would prefer to move the display class to a data-display attribute but that would require changes to the markup sanitizer, so not so simple.

Hmm yes, I'd like to avoid touching the sanitizer too much. So maybe a 2-3 words name is better, easier to search globally.

silverwind added a commit to silverwind/gitea that referenced this pull request Dec 14, 2024
@silverwind
Merge remote-tracking branch 'origin/main' into repotable
fb2d471 
* origin/main:
  Refactor markdown math render (go-gitea#32831)
  Add User-Agent for gitea's self-implemented lfs client. (go-gitea#32832)
@wxiaoguang wxiaoguang changed the title Refactor markdown math render Refactor markdown math render, add ` $expr$ ` syntax support Dec 15, 2024
@wxiaoguang wxiaoguang changed the title Refactor markdown math render, add ` $expr$ ` syntax support Refactor markdown math render, add dollor-backquote syntax support Dec 15, 2024
@wxiaoguang wxiaoguang added the type/enhancement An improvement of existing functionality label Dec 15, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/go Pull requests that update Go code type/enhancement An improvement of existing functionality

Projects

None yet

Milestone

1.23.0

Development

Successfully merging this pull request may close these issues.

4 participants

@wxiaoguang @silverwind @lunny @GiteaBot