Skip to content

Add support for getting password from file #32853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add support for getting password from file #32853

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docker/root/etc/s6/gitea/setup
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ if [ ! -f ${GITEA_CUSTOM}/conf/app.ini ]; then
if [ -n "$SECRET_KEY" ] && [ -z "$INSTALL_LOCK" ]; then
INSTALL_LOCK=true
fi
if [ "$DB_PASSWD_FILE" ]; then
DB_PASSWD=`cat $DB_PASSWD_FILE`;
Copy link
Member

@silverwind silverwind Dec 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
DB_PASSWD=`cat $DB_PASSWD_FILE`;
DB_PASSWD="$(cat $DB_PASSWD_FILE)";

backtick syntax is legacy.

Copy link
Contributor

@wxiaoguang wxiaoguang Dec 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before making more changes, I would suggest to use existing mechanisms. See my comments above.

Copy link
Member

@silverwind silverwind Dec 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I guess there are better solutions than to introduce _FILE variables for every variable.

fi

# Substitute the environment variables in the template
APP_NAME=${APP_NAME:-"Gitea: Git with a cup of tea"} \
Expand Down
Loading