Skip to content

fix textarea newline handle #32966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 25, 2024
Merged

fix textarea newline handle #32966

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9ef41a6
fix textarea newline handle
metiftikci Dec 23, 2024
a2203dd
fix task list on numbered list
metiftikci Dec 23, 2024
f5048c1
fine tune tests
wxiaoguang Dec 24, 2024
8b16a5e
revert increase list line number
metiftikci Dec 24, 2024
6bc0173
Merge branch 'main' into fix-textarea
GiteaBot Dec 25, 2024
720d7ca
Merge branch 'main' into fix-textarea
GiteaBot Dec 25, 2024
05ada52
Merge branch 'main' into fix-textarea
GiteaBot Dec 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion web_src/js/features/comp/EditorMarkdown.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,11 +92,12 @@ function handleNewline(textarea: HTMLTextAreaElement, e: Event) {
if (!line) {
// clear current line if we only have i.e. '1. ' and the user presses enter again to finish creating a list
textarea.value = value.slice(0, lineStart) + value.slice(lineEnd);
textarea.setSelectionRange(selStart - prefix.length, selStart - prefix.length);
} else {
// start a new line with the same indention and prefix
let newPrefix = prefix;
// a simple approach, otherwise it needs to parse the lines after the current line
if (/^\d+\./.test(prefix)) newPrefix = `1. ${newPrefix.slice(newPrefix.indexOf('.') + 2)}`;
Copy link
Member Author

@metiftikci metiftikci Dec 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what old code does

got it

Copy link
Contributor

@wxiaoguang wxiaoguang Dec 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment above // a simple approach, otherwise it needs to parse the lines after the current line

if (/^\d+\./.test(prefix)) newPrefix = `${Number(newPrefix.slice(0, newPrefix.indexOf('.'))) + 1}. `;
newPrefix = newPrefix.replace('[x]', '[ ]');
const newLine = `\n${indention}${newPrefix}`;
textarea.value = value.slice(0, selStart) + newLine + value.slice(selEnd);
Expand Down
Loading