Skip to content

feat(storage): Add options to skip version check for Minio storage to resolve compatible problem #33166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

feat(storage): Add options to skip version check for Minio storage to resolve compatible problem #33166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f6acdb
feat(storage): 为 Minio 存储添加版本检查跳过选项
xiandan-erizo Jan 9, 2025
1162741
Merge branch 'go-gitea:main' into main
xiandan-erizo Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/setting/storage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ type MinioStorageConfig struct {
ChecksumAlgorithm string `ini:"MINIO_CHECKSUM_ALGORITHM" json:",omitempty"`
ServeDirect bool `ini:"SERVE_DIRECT"`
BucketLookUpType string `ini:"MINIO_BUCKET_LOOKUP_TYPE" json:",omitempty"`
SkipVersionCheck bool `ini:"SKIP_VERSION_CHECK" json:",omitempty"`
Copy link
Member

@techknowlogick techknowlogick Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

Could you add a minio prefix to this setting, as well add documentation to the app.example.ini file?

}

func (cfg *MinioStorageConfig) ToShadow() {
Expand Down
4 changes: 3 additions & 1 deletion modules/storage/minio.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,9 @@ func NewMinioStorage(ctx context.Context, cfg *setting.Storage) (ObjectStorage,
// Otherwise even if the request itself fails (403, 404, etc), the code should still continue because the parameters seem "good" enough.
// Keep in mind that GetBucketVersioning requires "owner" to really succeed, so it can't be used to check the existence.
// Not using "BucketExists (HeadBucket)" because it doesn't include detailed failure reasons.
err = getBucketVersioning(ctx, minioClient, config.Bucket)
if !config.SkipVersionCheck {
err = getBucketVersioning(ctx, minioClient, config.Bucket)
}
if err != nil {
errResp, ok := err.(minio.ErrorResponse)
if !ok {
Expand Down
Loading