Skip to content

WIP: Fix container push #33214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

WIP: Fix container push #33214

wants to merge 1 commit into from

Conversation

@wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Jan 11, 2025 •
edited
Loading

Fix #26839, fix #25893

Update: this PR is wrong, discarded.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 11, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Jan 11, 2025
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Jan 11, 2025 •
edited
Loading

@KN4CK3R I managed to figure out the root problem of #26839 and #25893

This "quick fix" makes the push could succeed, but I think it is not good enough (actually not quite right)

Would you like to take a look and improve the fix?

@wxiaoguang wxiaoguang requested a review from KN4CK3R January 11, 2025 07:33
@wxiaoguang wxiaoguang marked this pull request as draft January 11, 2025 07:33
@wxiaoguang wxiaoguang changed the title Fix container push WIP: Fix container push Jan 13, 2025
@wxiaoguang wxiaoguang force-pushed the fix-container-push branch from 25d25b4 to f0d0c2e Compare June 15, 2025 12:07
wxiaoguang
wxiaoguang commented Jun 16, 2025
View reviewed changes
@wxiaoguang wxiaoguang closed this Jun 16, 2025
@wxiaoguang wxiaoguang deleted the fix-container-push branch June 16, 2025 06:58
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Jul 1, 2025 •
edited
Loading

This PR is wrong and unrelated, I think the problem should have been fixed on main branch (atm 1.25)

@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@KN4CK3R KN4CK3R Awaiting requested review from KN4CK3R

Assignees

No one assigned

Labels

lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code

Projects

None yet

Milestone

No milestone

3 participants

@wxiaoguang @techknowlogick @GiteaBot