Skip to content

Validate that the tag doesn't exist when creating a tag via the web #33241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jan 14, 2025
Merged

Validate that the tag doesn't exist when creating a tag via the web #33241

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
62d47e0
Validate that the tag doesn't exist when creating a tag via the web
kemzeb Jan 13, 2025
69984e5
PR feedback
kemzeb Jan 13, 2025
a3a6493
Fix typo in test
kemzeb Jan 13, 2025
7a5595c
add comments for the "string" type
wxiaoguang Jan 13, 2025
10c6287
Merge branch 'main' into fix/ui/release-post-with-tag-only
wxiaoguang Jan 13, 2025
5cf8947
fix legacy bugs
wxiaoguang Jan 13, 2025
7d77978
fix legacy bugs
wxiaoguang Jan 13, 2025
d190fb6
add comments
wxiaoguang Jan 13, 2025
982cb1f
fix test
wxiaoguang Jan 13, 2025
3ca836c
rewrite tests
wxiaoguang Jan 13, 2025
1f8952f
fix test
wxiaoguang Jan 13, 2025
f68bee5
add more tests
wxiaoguang Jan 13, 2025
57aef6d
fix tag-only button logic
wxiaoguang Jan 13, 2025
be79b34
add more comments
wxiaoguang Jan 13, 2025
43c5100
improve comment
wxiaoguang Jan 13, 2025
7cd7d60
improve test
wxiaoguang Jan 14, 2025
6633188
Merge branch 'main' into fix/ui/release-post-with-tag-only
wxiaoguang Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion routers/web/repo/release.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,7 @@ func NewReleasePost(ctx *context.Context) {
return
}
} else {
if !rel.IsTag {
if len(form.TagOnly) > 0 && rel.IsTag {
ctx.Data["Err_TagName"] = true
ctx.RenderWithErr(ctx.Tr("repo.release.tag_name_already_exist"), tplReleaseNew, &form)
return
Expand Down
Loading