Added Description Field for Secrets and Variables #33524
Conversation
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/translation
modifies/api
techknowlogick
left a comment
techknowlogick
left a comment
There was a problem hiding this comment.
Thanks for this PR!
A few tiny things that did it so far.
| </div> | ||
| <div class="field"> | ||
| <label for="secret-description">{{ctx.Locale.Tr "secrets.creation.description"}}</label> | ||
| <input autofocus |
There was a problem hiding this comment.
Probably best to leave autofocus off of this field as the others already
| @@ -0,0 +1,20 @@ | |||
| // Copyright 2024 The Gitea Authors. All rights reserved. | |||
| </div> | ||
| <div class="field"> | ||
| <label for="dialog-variable-description">{{ctx.Locale.Tr "secrets.creation.description"}}</label> | ||
| <input autofocus |
| Name: "description", | ||
| Description: "some description", | ||
| ExpectedStatus: http.StatusCreated, | ||
| }, |
There was a problem hiding this comment.
Could you add a test that leaves out the description field, just to ensure that it'll fall back to the default?
There was a problem hiding this comment.
These tests only check if descriptions can be written. In reality, the default tests written at api_repo_secrets_test.go#L33 are cases without descriptions. I haven’t thought of any other test cases yet. Any suggestions?
|
@LaoQi i saw you closed this, was that intentional? |
|
There too many lint error on it. After re-linting the code, I will submit a new pull request. |
3 participants
Basic support for #33484