Cache commit verification #33616
Closed
Cache commit verification #33616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
wxiaoguang
reviewed
Feb 17, 2025
| src := t.AvatarLinkWithSize(au.ctx, size*setting.Avatar.RenderedSizeFactor) | ||
| if src != "" { | ||
| return AvatarHTML(src, size, class, t.DisplayName()) | ||
| if t != nil && t.ID != 0 { |
wxiaoguang
reviewed
Feb 17, 2025
Comment on lines
+46
to
+54
| key := committer.Email | ||
| if c.Signature != nil { | ||
| key += fmt.Sprintf("-%s", c.Signature.Signature) | ||
| } | ||
| verification, ok := cachedVerifications[key] | ||
| if !ok { | ||
| verification = asymkey_service.ParseCommitWithSignatureCommitter(ctx, c.Commit, committer) | ||
| cachedVerifications[key] = verification | ||
| } |
Contributor
There was a problem hiding this comment.
How could it be right? Each commit's Signature is different from others?
Member
Author
There was a problem hiding this comment.
In the ParseCommitWithSignatureCommitter, the returned result will only be related to commit.Signature and email.
Contributor
There was a problem hiding this comment.
ParseCommitWithSignatureCommitter returns *asymkey_model.CommitVerification
type CommitVerification struct {
Verified bool
Warning bool
Reason string
SigningUser *user_model.User
CommittingUser *user_model.User
SigningEmail string
SigningKey *GPGKey
SigningSSHKey *PublicKey
TrustStatus string
}
Then this pointer is reused for different commits?
This comment was marked as off-topic.
This comment was marked as off-topic.
Member
Author
|
It seems it needs more refactor before sending this pull request. Closed at the moment. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading the commit list, the verification will be checked. This PR cached the same verification on the same commits list to avoid duplicated computing.