Make OAuth redirect URIs configurable via environment variable #33618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
Contributor
|
But why? These builtin apps should only accept "local" URLs. It is used by desktop applications. |
wxiaoguang
added
the
issue/needs-feedback
Author
|
I tried and searched a lot to fix this internal IP problem, but I couldn't
find a way to do it.
…On Mon, Feb 17, 2025 at 9:09 AM wxiaoguang ***@***.***> wrote:
But why? These builtin apps should only accept "local" URLs. It is used by
desktop applications.
—
Reply to this email directly, view it on GitHub
<#33618 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AT6LICJ7VWCXGJIEVFERYED2QFY2XAVCNFSM6AAAAABXIO3WXCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRSGEYDONRTHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: wxiaoguang]*wxiaoguang* left a comment (go-gitea/gitea#33618)
<#33618 (comment)>
But why? These builtin apps should only accept "local" URLs. It is used by
desktop applications.
—
Reply to this email directly, view it on GitHub
<#33618 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AT6LICJ7VWCXGJIEVFERYED2QFY2XAVCNFSM6AAAAABXIO3WXCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRSGEYDONRTHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
Could you elaborate what problem you were trying to fix? Maybe I could help if we could figure out the problem clearly. |
Author
|
Naturally, instead of 127.0.0.1, the URL address should be (
git.timely-project.ir). Isn't that right?
…On Mon, Feb 17, 2025 at 1:00 PM wxiaoguang ***@***.***> wrote:
I tried and searched a lot to fix this internal IP problem, but I couldn't
find a way to do it.
Could you elaborate what problem you were trying to fix? Maybe I could
help if we could figure out the problem clearly.
—
Reply to this email directly, view it on GitHub
<#33618 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AT6LICMT56SKLT3VIXOCAVD2QGT4DAVCNFSM6AAAAABXIO3WXCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRSGUZTIMRVGM>
.
You are receiving this because you commented.Message ID:
***@***.***>
[image: wxiaoguang]*wxiaoguang* left a comment (go-gitea/gitea#33618)
<#33618 (comment)>
I tried and searched a lot to fix this internal IP problem, but I couldn't
find a way to do it.
Could you elaborate what problem you were trying to fix? Maybe I could
help if we could figure out the problem clearly.
—
Reply to this email directly, view it on GitHub
<#33618 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AT6LICMT56SKLT3VIXOCAVD2QGT4DAVCNFSM6AAAAABXIO3WXCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRSGUZTIMRVGM>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Contributor
Could you provide more details about the "URL"? Or how to reproduce the problem with a demo setup? There are various kinds of "URLs" in a web app. For the URLs in this PR: they are all for builtin oauth2 apps which are only used by some well-known git clients, I think none of them is related to a Gitea site's public URL. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make OAuth redirect URIs configurable via environment variable