Skip to content

Adding Github Theme to Gitea and Setting It as the Default Theme #33624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Adding Github Theme to Gitea and Setting It as the Default Theme #33624

wants to merge 1 commit into from

Conversation

@ExplodingDragon
Copy link
Contributor

@ExplodingDragon ExplodingDragon commented Feb 17, 2025 •
edited
Loading

Presumptuous Attempt, Do Not Merge

Include https://github.com/lutinglt/gitea-github-theme in Gitea and set it as default theme.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 17, 2025
@ExplodingDragon ExplodingDragon marked this pull request as draft February 17, 2025 08:50
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/internal labels Feb 17, 2025
@ExplodingDragon ExplodingDragon changed the title [Presumptuous Attempt] Adding the Github Theme to Gitea and Setting It as the Default Theme Adding Github Theme to Gitea and Setting It as the Default Theme Feb 17, 2025
@github-actions github-actions bot added the docs-update-needed The document needs to be updated synchronously label Feb 17, 2025
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Feb 17, 2025

Hmm, the "official" themes should be managed in the Gitea's repo, because we refactor the frontend a lot, using external theme files will break frequently.

@ExplodingDragon
Copy link
Contributor Author

ExplodingDragon commented Feb 17, 2025

Hmm, the "official" themes should be managed in the Gitea's repo, because we refactor the frontend a lot, using external theme files will break frequently.

@wxiaoguang Yes, this PR was never intended to be merged into the main branch. It was simply provided as a reference example for custom theme packaging.

@silverwind
Copy link
Member

silverwind commented Feb 17, 2025 •
edited
Loading

For the record: If the default theme is ever changed, a database migration needs to be added to migrate users that had the previous theme set get migrated to the new theme.

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Feb 17, 2025

For the record: If the default theme is ever changed, a database migration needs to be added to migrate users that had the previous theme set get migrated to the new theme.

I think it is not needed anymore in modern Gitea. I have made the theme system could work with fallback correctly in Initial support for colorblindness-friendly themes (#30625)

image

@silverwind
Copy link
Member

silverwind commented Feb 17, 2025 •
edited
Loading

For the record: If the default theme is ever changed, a database migration needs to be added to migrate users that had the previous theme set get migrated to the new theme.

I think it is not needed anymore in modern Gitea. I have made the theme system could work with fallback correctly in Initial support for colorblindness-friendly themes (#30625)

image

You mean users that select the default theme will store user.Theme = "" in the database?

techknowlogick
techknowlogick requested changes Feb 17, 2025
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please disregard this "review", it is solely to ensure that it can't be accidentally merged

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 17, 2025
@techknowlogick
Copy link
Member

techknowlogick commented Feb 17, 2025

Oh neat! I don't think I've seen this custom theme yet (I will have to take a double check of the "awesome" list), but it's rather exciting!
There was previously discussion of having some sort of theme "store" (not actually a store, but a listing of custom themes) along with screenshots etc.. similar to how hugo has one, and would allow for assistance in allowing users to use it, not sure of where that ended up though.

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Mar 28, 2025

Do we need to keep this PR open? If you'd like to do experiments, you could test your changes locally.

@wxiaoguang wxiaoguang added the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label Mar 28, 2025
@ExplodingDragon
Copy link
Contributor Author

ExplodingDragon commented Mar 28, 2025

Do we need to keep this PR open? If you'd like to do experiments, you could test your changes locally.

No Thanks. I will close it.

@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@techknowlogick techknowlogick techknowlogick requested changes

Assignees

No one assigned

Labels

docs-update-needed The document needs to be updated synchronously issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged modifies/go Pull requests that update Go code modifies/internal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ExplodingDragon @wxiaoguang @silverwind @techknowlogick @GiteaBot