Skip to content

Disable vet as part of go test #33662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 3, 2025
Merged

Disable vet as part of go test #33662

Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7342c9e
Disable `vet` as part of `go test`
silverwind Feb 20, 2025
65c3ab9
run vet without -vettool
silverwind Feb 20, 2025
0816ef4
Merge branch 'main' into novet
GiteaBot Mar 1, 2025
06ea88a
remove go vet and update print and echo
silverwind Mar 1, 2025
32826ff
rename lint-go-vet to lint-go-gitea-vet
silverwind Mar 1, 2025
3e03d0b
move -vet=off to GOTESTFLAGS
silverwind Mar 1, 2025
0e656d1
allow override of GOTESTFLAGS
silverwind Mar 1, 2025
dce15b2
re-enable
silverwind Mar 1, 2025
3e43bae
Merge branch 'main' into novet
GiteaBot Mar 3, 2025
0e036c8
Merge branch 'main' into novet
GiteaBot Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,7 @@ lint-go-windows:
.PHONY: lint-go-vet
lint-go-vet: ## lint go files with vet
@echo "Running go vet..."
@$(GO) vet ./...
@GOOS= GOARCH= $(GO) build code.gitea.io/gitea-vet
@$(GO) vet -vettool=gitea-vet ./...

Expand Down Expand Up @@ -413,7 +414,7 @@ test: test-frontend test-backend ## test everything
.PHONY: test-backend
test-backend: ## test frontend files
@echo "Running go test with $(GOTESTFLAGS) -tags '$(TEST_TAGS)'..."
@$(GO) test $(GOTESTFLAGS) -tags='$(TEST_TAGS)' $(GO_TEST_PACKAGES)
@$(GO) test $(GOTESTFLAGS) -tags='$(TEST_TAGS)' -vet=off $(GO_TEST_PACKAGES)

.PHONY: test-frontend
test-frontend: node_modules ## test backend files
Expand Down
Loading