Skip to content

Allow admin to change user's type #33758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Allow admin to change user's type #33758

wants to merge 1 commit into from

Conversation

@lunny
Copy link
Member

@lunny lunny commented Mar 1, 2025

This will make a user as reserved or recover easier than before.

@lunny lunny added the type/enhancement An improvement of existing functionality label Mar 1, 2025
@lunny lunny added this to the 1.24.0 milestone Mar 1, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 1, 2025
@github-actions github-actions bot added modifies/translation modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Mar 1, 2025
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Mar 1, 2025

Have you clarified the behaviors for different user types?

For example: user password? user tokens? oauth applications?

@techknowlogick
Copy link
Member

techknowlogick commented Mar 1, 2025

Please add screenshots

wxiaoguang
wxiaoguang requested changes Mar 1, 2025
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to clarify all details when changing the user type, for example: to a "bot" user: what happens to the user password? user tokens? oauth applications?

Why an "org" user could become an "individual" user?

Totally a mess.

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 1, 2025
@lunny
Copy link
Member Author

lunny commented Mar 1, 2025

Need to clarify all details when changing the user type, for example: to a "bot" user: what happens to the user password? user tokens? oauth applications?

Why an "org" user could become an "individual" user?

Totally a mess.

I think you are right. I actually want to mark user as reversed or unreserved in this PR. I will close this one and proposal a new one.

@lunny lunny closed this Mar 1, 2025
@lunny lunny deleted the lunny/allow_admin_change_type branch March 1, 2025 21:00
@lunny lunny removed this from the 1.24.0 milestone Mar 1, 2025
@go-gitea go-gitea locked as resolved and limited conversation to collaborators May 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wxiaoguang wxiaoguang wxiaoguang requested changes

Assignees

No one assigned

Labels

lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/translation type/enhancement An improvement of existing functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lunny @wxiaoguang @techknowlogick @GiteaBot