Fix user retrieved from token late #33786
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
Contributor
|
Thank you for the PR, I haven't looked into the problem and have no idea whether there was any real problem. But the CI reports a lot of failed tests. |
wxiaoguang
added
the
issue/needs-feedback
Contributor
|
Do you have more ideas? |
Contributor
|
Thank you for the PR, inactive for long time, feel free to reopen if there would be new progress. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case an user is pulling from a LFS repository, the user should be retrieved from the token. This happens already in the current code, but after using an empty user variable for retrieving the permissions for the user on the specific repository.
The incorrect order seems to only impact the logged messages:
Otherwise it doesn't seem to impact pulls or pushed.
The pull request fixes this behaviour and had been tested locally already.