Skip to content

Drop timeout for requests made to the internal hook api #33947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 21, 2025
Merged

Drop timeout for requests made to the internal hook api #33947

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f4061d7
Drop timeout for requests made to the internal hook api
Mik4sa Mar 21, 2025
bb3560c
fix
wxiaoguang Mar 21, 2025
a8c2c56
Merge pull request #1 from wxiaoguang/fix-git-hook-timeout
Mik4sa Mar 21, 2025
bd80d6a
Update modules/private/hook.go
wxiaoguang Mar 21, 2025
077040a
Merge branch 'main' into configurable-internal-hook-timeout
GiteaBot Mar 21, 2025
3748219
Merge branch 'main' into configurable-internal-hook-timeout
GiteaBot Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions modules/private/hook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import (
"context"
"fmt"
"net/url"
"time"

"code.gitea.io/gitea/modules/git"
"code.gitea.io/gitea/modules/repository"
Expand Down Expand Up @@ -86,7 +85,6 @@ type HookProcReceiveRefResult struct {
func HookPreReceive(ctx context.Context, ownerName, repoName string, opts HookOptions) ResponseExtra {
reqURL := setting.LocalURL + fmt.Sprintf("api/internal/hook/pre-receive/%s/%s", url.PathEscape(ownerName), url.PathEscape(repoName))
req := newInternalRequestAPI(ctx, reqURL, "POST", opts)
req.SetReadWriteTimeout(time.Duration(60+len(opts.OldCommitIDs)) * time.Second)
_, extra := requestJSONResp(req, &ResponseText{})
return extra
}
Expand All @@ -95,7 +93,6 @@ func HookPreReceive(ctx context.Context, ownerName, repoName string, opts HookOp
func HookPostReceive(ctx context.Context, ownerName, repoName string, opts HookOptions) (*HookPostReceiveResult, ResponseExtra) {
reqURL := setting.LocalURL + fmt.Sprintf("api/internal/hook/post-receive/%s/%s", url.PathEscape(ownerName), url.PathEscape(repoName))
req := newInternalRequestAPI(ctx, reqURL, "POST", opts)
req.SetReadWriteTimeout(time.Duration(60+len(opts.OldCommitIDs)) * time.Second)
return requestJSONResp(req, &HookPostReceiveResult{})
}

Expand All @@ -104,7 +101,6 @@ func HookProcReceive(ctx context.Context, ownerName, repoName string, opts HookO
reqURL := setting.LocalURL + fmt.Sprintf("api/internal/hook/proc-receive/%s/%s", url.PathEscape(ownerName), url.PathEscape(repoName))

req := newInternalRequestAPI(ctx, reqURL, "POST", opts)
req.SetReadWriteTimeout(time.Duration(60+len(opts.OldCommitIDs)) * time.Second)
return requestJSONResp(req, &HookProcReceiveResult{})
}

Expand Down