User badge model fixes for RemoveUserBadges and AddUserBadges #33950
+138
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this adds a db migration, and replaces an index on user_id with a compound unique index on (user_id, badge_id) that should cover the same queries as the old index
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33949
RemoveUserBadgesimplementation is fixed to avoid an ORM construct that produced invalid SQL (see the referenced issue for details).AddUserBadgeswon't be able to produce duplicate badges anymore due to a unique constraint added to theuser_badgetable. An attempt to add a duplicate badge will result in an error.The corresponding database migration is supposed to delete any potential badge duplicates existing before.
A new test is added to demonstrate these fixes.