Skip to content

Return default avatar url when user id is zero rather than updating database #34094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 2, 2025
Merged

Return default avatar url when user id is zero rather than updating database #34094

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
beed81a
Return default avatar url when user id is zero rather than updating d…
lunny Apr 1, 2025
82ae3eb
for all user with id less than zero
lunny Apr 1, 2025
35687e9
Update models/user/avatar.go
lunny Apr 1, 2025
c377cb7
Merge branch 'main' into lunny/fix_avatar_url
GiteaBot Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion models/user/avatar.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,9 @@ func GenerateRandomAvatar(ctx context.Context, u *User) error {

// AvatarLinkWithSize returns a link to the user's avatar with size. size <= 0 means default size
func (u *User) AvatarLinkWithSize(ctx context.Context, size int) string {
if u.IsGhost() || u.IsGiteaActions() {
// ghost user was deleted, Gitea actions is a bot user, 0 means the user should be a virtual user
// which comes from git configure information
if u.IsGhost() || u.IsGiteaActions() || u.ID < 0 {
return avatars.DefaultAvatarLink()
}

Expand Down