Use tag's database num commits instead of read the commit counts from git data#34191
Closed
lunny wants to merge 3 commits intogo-gitea:mainfrom
Closed
Use tag's database num commits instead of read the commit counts from git data#34191lunny wants to merge 3 commits intogo-gitea:mainfrom
lunny wants to merge 3 commits intogo-gitea:mainfrom
Conversation
Contributor
|
I do not think it's right to keep patching the old code by more hacky code. Why can't it get a clear solution? |
Contributor
|
Although the goal is good, I do not think the approach is right or there is enough time to take it into 1.24 |
Member
Author
|
This should be replaced by #34311 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It will be slow to get the commits count for a tag of a big repository. But the commits count has been stored in the table
releaseof the database. We could just use that value.