Skip to content

Fix the issue of abnormal interface when there is no issue-item on the project page #34791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 20, 2025
Merged

Fix the issue of abnormal interface when there is no issue-item on the project page #34791

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3e50a71
fix #34785
kerwin612 Jun 20, 2025
d28059b
Merge branch 'main' into fix/34785
kerwin612 Jun 20, 2025
d48f06b
fix
kerwin612 Jun 20, 2025
4f51fca
Merge remote-tracking branch 'kerwin612/fix/34785' into fix/34785
kerwin612 Jun 20, 2025
d6e0a62
Merge branch 'main' into fix/34785
wxiaoguang Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions web_src/css/features/projects.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
}

.project-column {
min-height: max(calc(100vh - 400px), 300px);
Copy link
Contributor

@wxiaoguang wxiaoguang Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think min-height: min(100vh, 200px); (or 300px) is better.

Copy link
Contributor

@wxiaoguang wxiaoguang Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And we should put the styles on #project-board.

It already has max-height: calc(100vh - 120px);

Copy link
Member Author

@kerwin612 kerwin612 Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

06807c4a-d4a2-42cb-b4f3-34acaa70e69c
min-height: min(100vh, 200px);Personally, I feel it's a bit lacking in aesthetics. Of course, the decision is yours.

Copy link
Contributor

@wxiaoguang wxiaoguang Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually GitHub doesn't set min-height. It always make the column full-height

But I think it's fine to use any solution at the moment.

image

flex: 0 0 auto;
display: flex;
flex-direction: column;
Expand Down