Skip to content

Remove useless code in the repository's setting post related to visibility change #34812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Remove useless code in the repository's setting post related to visibility change #34812

wants to merge 11 commits into from
+0 −6

Conversation

@lunny
Copy link
Member

@lunny lunny commented Jun 21, 2025 •
edited
Loading

Since repository visibility change have been moved to a standalone button, these code is useless.

@lunny lunny added type/bug backport/v1.24 This PR should be backported to Gitea 1.24 labels Jun 21, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 21, 2025
@lunny lunny requested a review from wxiaoguang June 21, 2025 19:58
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jun 21, 2025
@lunny lunny changed the title Fix a bug when setting repository private Remove unused code when setting repository private Jun 21, 2025
wxiaoguang
wxiaoguang reviewed Jun 22, 2025
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not keep it?

@wxiaoguang wxiaoguang marked this pull request as draft June 28, 2025 07:19
@wxiaoguang wxiaoguang removed the backport/v1.24 This PR should be backported to Gitea 1.24 label Jun 28, 2025
@lunny
Copy link
Member Author

lunny commented Aug 1, 2025 •
edited
Loading

Why not keep it?

What’s the purpose of keeping it? As far as I can tell, the form.Private field is assigned but never used afterward.

image

Maybe it's a typo? It should be repo.Private = but not form.Private =? @wxiaoguang
I updated the code. Now it should be a bug fix.

@lunny lunny changed the title Remove unused code when setting repository private Update the repository's visibility when it's necessary after changing settings Aug 1, 2025
@lunny lunny added this to the 1.26.0 milestone Sep 30, 2025
@lunny lunny marked this pull request as ready for review September 30, 2025 00:02
Zettat123
Zettat123 reviewed Oct 20, 2025
View reviewed changes
@lunny lunny changed the title Update the repository's visibility when it's necessary after changing settings Remove useless code in the repository's setting post related to visibility change Oct 22, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wxiaoguang wxiaoguang wxiaoguang left review comments

+1 more reviewer

@Zettat123 Zettat123 Zettat123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/go Pull requests that update Go code type/miscellaneous

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

4 participants

@lunny @wxiaoguang @Zettat123 @GiteaBot