enforce nolint scope

.golangci.yml

@@ -45,6 +45,9 @@ linters:
               desc: do not use the ini package, use gitea's config system instead
             - pkg: gitea.com/go-chi/cache
               desc: do not use the go-chi cache package, use gitea's cache system
+    nolintlint:
+      # require-explanation: true
+      require-specific: true
     gocritic:
       disabled-checks:
         - ifElseChain

models/asymkey/ssh_key_parse.go

@@ -208,7 +208,7 @@ func SSHNativeParsePublicKey(keyLine string) (string, int, error) {
 
 	// The ssh library can parse the key, so next we find out what key exactly we have.
 	switch pkey.Type() {
-	case ssh.KeyAlgoDSA: //nolint
+	case ssh.KeyAlgoDSA: //nolint:staticcheck // it's deprecated
 		rawPub := struct {
 			Name       string
 			P, Q, G, Y *big.Int

models/issues/issue_search.go

@@ -24,7 +24,7 @@ import (
 const ScopeSortPrefix = "scope-"
 
 // IssuesOptions represents options of an issue.
-type IssuesOptions struct { //nolint
+type IssuesOptions struct { //nolint:revive // export stutter, not a large issue
 	Paginator          *db.ListOptions
 	RepoIDs            []int64 // overwrites RepoCond if the length is not 0
 	AllPublic          bool    // include also all public repositories

models/migrations/v1_10/v100.go

@@ -1,7 +1,7 @@
 // Copyright 2019 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_10 //nolint
+package v1_10 //nolint:revive // underscore in migration packages isn't a large issue
 
 import (
 	"net/url"

models/migrations/v1_10/v101.go

@@ -1,7 +1,7 @@
 // Copyright 2019 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_10 //nolint
+package v1_10 //nolint:revive // underscore in migration packages isn't a large issue
 
 import (
 	"xorm.io/xorm"

models/migrations/v1_10/v88.go

@@ -1,7 +1,7 @@
 // Copyright 2019 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_10 //nolint
+package v1_10 //nolint:revive // underscore in migration packages isn't a large issue
 
 import (
 	"crypto/sha1"

models/migrations/v1_10/v89.go

@@ -1,7 +1,7 @@
 // Copyright 2019 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_10 //nolint
+package v1_10 //nolint:revive // underscore in migration packages isn't a large issue
 
 import "xorm.io/xorm"
 

models/migrations/v1_10/v90.go

@@ -1,7 +1,7 @@
 // Copyright 2019 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_10 //nolint
+package v1_10 //nolint:revive // underscore in migration packages isn't a large issue
 
 import "xorm.io/xorm"
 

models/migrations/v1_10/v91.go

@@ -1,7 +1,7 @@
 // Copyright 2019 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_10 //nolint
+package v1_10 //nolint:revive // underscore in migration packages isn't a large issue
 
 import "xorm.io/xorm"
 

models/migrations/v1_10/v92.go

@@ -1,7 +1,7 @@
 // Copyright 2019 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_10 //nolint
+package v1_10 //nolint:revive // underscore in migration packages isn't a large issue
 
 import (
 	"xorm.io/builder"

models/migrations/v1_10/v93.go

@@ -1,7 +1,7 @@
 // Copyright 2019 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_10 //nolint
+package v1_10 //nolint:revive // underscore in migration packages isn't a large issue
 
 import "xorm.io/xorm"
 

models/migrations/v1_10/v94.go

@@ -1,7 +1,7 @@
 // Copyright 2019 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_10 //nolint
+package v1_10 //nolint:revive // underscore in migration packages isn't a large issue
 
 import "xorm.io/xorm"
 

models/migrations/v1_10/v95.go

@@ -1,7 +1,7 @@
 // Copyright 2019 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_10 //nolint
+package v1_10 //nolint:revive // underscore in migration packages isn't a large issue
 
 import "xorm.io/xorm"
 

models/migrations/v1_10/v96.go

@@ -1,7 +1,7 @@
 // Copyright 2019 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_10 //nolint
+package v1_10 //nolint:revive // underscore in migration packages isn't a large issue
 
 import (
 	"path/filepath"

models/migrations/v1_10/v97.go

@@ -1,7 +1,7 @@
 // Copyright 2019 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_10 //nolint
+package v1_10 //nolint:revive // underscore in migration packages isn't a large issue
 
 import "xorm.io/xorm"
 

models/migrations/v1_10/v98.go

@@ -1,7 +1,7 @@
 // Copyright 2019 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_10 //nolint
+package v1_10 //nolint:revive // underscore in migration packages isn't a large issue
 
 import "xorm.io/xorm"
 

models/migrations/v1_10/v99.go

@@ -1,7 +1,7 @@
 // Copyright 2019 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_10 //nolint
+package v1_10 //nolint:revive // underscore in migration packages isn't a large issue
 
 import (
 	"code.gitea.io/gitea/modules/timeutil"

models/migrations/v1_11/v102.go

@@ -1,7 +1,7 @@
 // Copyright 2019 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_11 //nolint
+package v1_11 //nolint:revive // underscore in migration packages isn't a large issue
 
 import (
 	"code.gitea.io/gitea/models/migrations/base"

models/migrations/v1_11/v103.go

@@ -1,7 +1,7 @@
 // Copyright 2019 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_11 //nolint
+package v1_11 //nolint:revive // underscore in migration packages isn't a large issue
 
 import (
 	"xorm.io/xorm"

models/migrations/v1_11/v104.go

@@ -1,7 +1,7 @@
 // Copyright 2019 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_11 //nolint
+package v1_11 //nolint:revive // underscore in migration packages isn't a large issue
 
 import (
 	"code.gitea.io/gitea/models/migrations/base"

models/migrations/v1_11/v105.go

@@ -1,7 +1,7 @@
 // Copyright 2019 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_11 //nolint
+package v1_11 //nolint:revive // underscore in migration packages isn't a large issue
 
 import (
 	"xorm.io/xorm"

models/migrations/v1_11/v106.go

@@ -1,7 +1,7 @@
 // Copyright 2019 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_11 //nolint
+package v1_11 //nolint:revive // underscore in migration packages isn't a large issue
 
 import (
 	"xorm.io/xorm"

models/migrations/v1_11/v107.go

@@ -1,7 +1,7 @@
 // Copyright 2019 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_11 //nolint
+package v1_11 //nolint:revive // underscore in migration packages isn't a large issue
 
 import (
 	"xorm.io/xorm"

models/migrations/v1_11/v108.go

@@ -1,7 +1,7 @@
 // Copyright 2019 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_11 //nolint
+package v1_11 //nolint:revive // underscore in migration packages isn't a large issue
 
 import (
 	"xorm.io/xorm"

models/migrations/v1_11/v109.go

@@ -1,7 +1,7 @@
 // Copyright 2019 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_11 //nolint
+package v1_11 //nolint:revive // underscore in migration packages isn't a large issue
 
 import (
 	"xorm.io/xorm"

models/migrations/v1_11/v110.go

@@ -1,7 +1,7 @@
 // Copyright 2019 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_11 //nolint
+package v1_11 //nolint:revive // underscore in migration packages isn't a large issue
 
 import (
 	"xorm.io/xorm"

models/migrations/v1_11/v111.go

@@ -1,7 +1,7 @@
 // Copyright 2019 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_11 //nolint
+package v1_11 //nolint:revive // underscore in migration packages isn't a large issue
 
 import (
 	"fmt"

models/migrations/v1_11/v112.go

@@ -1,7 +1,7 @@
 // Copyright 2019 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_11 //nolint
+package v1_11 //nolint:revive // underscore in migration packages isn't a large issue
 
 import (
 	"fmt"

models/migrations/v1_11/v113.go

@@ -1,7 +1,7 @@
 // Copyright 2019 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_11 //nolint
+package v1_11 //nolint:revive // underscore in migration packages isn't a large issue
 
 import (
 	"fmt"

models/migrations/v1_11/v114.go

@@ -1,7 +1,7 @@
 // Copyright 2019 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_11 //nolint
+package v1_11 //nolint:revive // underscore in migration packages isn't a large issue
 
 import (
 	"net/url"

models/migrations/v1_11/v115.go

@@ -1,7 +1,7 @@
 // Copyright 2019 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_11 //nolint
+package v1_11 //nolint:revive // underscore in migration packages isn't a large issue
 
 import (
 	"crypto/md5"

models/migrations/v1_11/v116.go

@@ -1,7 +1,7 @@
 // Copyright 2019 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_11 //nolint
+package v1_11 //nolint:revive // underscore in migration packages isn't a large issue
 
 import (
 	"xorm.io/xorm"

models/migrations/v1_12/v117.go

@@ -1,7 +1,7 @@
 // Copyright 2020 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_12 //nolint
+package v1_12 //nolint:revive // underscore in migration packages isn't a large issue
 
 import (
 	"xorm.io/xorm"

models/migrations/v1_12/v118.go

@@ -1,7 +1,7 @@
 // Copyright 2019 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_12 //nolint
+package v1_12 //nolint:revive // underscore in migration packages isn't a large issue
 
 import (
 	"xorm.io/xorm"

models/migrations/v1_12/v119.go

@@ -1,7 +1,7 @@
 // Copyright 2020 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_12 //nolint
+package v1_12 //nolint:revive // underscore in migration packages isn't a large issue
 
 import (
 	"xorm.io/xorm"

models/migrations/v1_12/v120.go

@@ -1,7 +1,7 @@
 // Copyright 2020 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_12 //nolint
+package v1_12 //nolint:revive // underscore in migration packages isn't a large issue
 
 import (
 	"xorm.io/xorm"

models/migrations/v1_12/v121.go

@@ -1,7 +1,7 @@
 // Copyright 2020 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_12 //nolint
+package v1_12 //nolint:revive // underscore in migration packages isn't a large issue
 
 import "xorm.io/xorm"
 

models/migrations/v1_12/v122.go

@@ -1,7 +1,7 @@
 // Copyright 2020 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_12 //nolint
+package v1_12 //nolint:revive // underscore in migration packages isn't a large issue
 
 import (
 	"xorm.io/xorm"

models/migrations/v1_12/v123.go

@@ -1,7 +1,7 @@
 // Copyright 2020 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_12 //nolint
+package v1_12 //nolint:revive // underscore in migration packages isn't a large issue
 
 import (
 	"xorm.io/xorm"

models/migrations/v1_12/v124.go

@@ -1,7 +1,7 @@
 // Copyright 2020 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_12 //nolint
+package v1_12 //nolint:revive // underscore in migration packages isn't a large issue
 
 import (
 	"xorm.io/xorm"

models/migrations/v1_12/v125.go

@@ -1,7 +1,7 @@
 // Copyright 2020 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_12 //nolint
+package v1_12 //nolint:revive // underscore in migration packages isn't a large issue
 
 import (
 	"fmt"

models/migrations/v1_12/v126.go

@@ -1,7 +1,7 @@
 // Copyright 2020 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_12 //nolint
+package v1_12 //nolint:revive // underscore in migration packages isn't a large issue
 
 import (
 	"xorm.io/builder"

models/migrations/v1_12/v127.go

@@ -1,7 +1,7 @@
 // Copyright 2020 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_12 //nolint
+package v1_12 //nolint:revive // underscore in migration packages isn't a large issue
 
 import (
 	"fmt"

models/migrations/v1_12/v128.go

@@ -1,7 +1,7 @@
 // Copyright 2020 The Gitea Authors. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-package v1_12 //nolint
+package v1_12 //nolint:revive // underscore in migration packages isn't a large issue
 
 import (
 	"fmt"