enforce nolint scope

services/repository/files/file_test.go

@@ -10,9 +10,9 @@ import (
 )
 
 func TestCleanUploadFileName(t *testing.T) {
-	assert.Empty(t, CleanGitTreePath(""))
-	assert.Empty(t, CleanGitTreePath("."))
+	assert.Equal(t, "", CleanGitTreePath(""))  //nolint:testifylint // for readability and alignment
+	assert.Equal(t, "", CleanGitTreePath(".")) //nolint:testifylint // for readability and alignment
 	assert.Equal(t, "a/b", CleanGitTreePath("a/b"))
-	assert.Empty(t, CleanGitTreePath(".git/b"))
-	assert.Empty(t, CleanGitTreePath("a/.git"))
+	assert.Equal(t, "", CleanGitTreePath(".git/b")) //nolint:testifylint // for readability and alignment
+	assert.Equal(t, "", CleanGitTreePath("a/.git")) //nolint:testifylint // for readability and alignment
 }

services/user/update.go

@@ -137,7 +137,7 @@ func UpdateUser(ctx context.Context, u *user_model.User, opts *UpdateOptions) er
 		} else if !user_model.IsLastAdminUser(ctx, u) /* not the last admin */ {
 			u.IsAdmin = opts.IsAdmin.Value().FieldValue // it's safe to change it from false to true (not the last admin)
 			cols = append(cols, "is_admin")
-		} else /* IsAdmin=false but this is the last admin user */ { //nolint:gocritic // could flatten the condition, no idea how to flatten comments at the moment
+		} else /* IsAdmin=false but this is the last admin user */ { //nolint:gocritic // make it easier to read
 			if !opts.IsAdmin.Value().FromSync {
 				return user_model.ErrDeleteLastAdminUser{UID: u.ID}
 			}