Skip to content

Don't send trigger for a pending review's comment create/update/delete #34928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 3, 2025
Merged

Don't send trigger for a pending review's comment create/update/delete #34928

merged 3 commits into from
Jul 3, 2025

Conversation

@lunny
Copy link
Member

@lunny lunny commented Jul 2, 2025 •
edited
Loading

Fix #18846
Fix #34924

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 2, 2025
@lunny lunny added type/bug backport/v1.24 This PR should be backported to Gitea 1.24 and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 2, 2025
@github-actions github-actions bot added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/go Pull requests that update Go code and removed type/bug backport/v1.24 This PR should be backported to Gitea 1.24 labels Jul 2, 2025
@lunny lunny added type/bug backport/v1.24 This PR should be backported to Gitea 1.24 labels Jul 2, 2025
@wxiaoguang
Copy link
Contributor 

func shouldSendIssueChangeNotification(...) bool {
}

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 2, 2025
@lunny
Copy link
Member Author

lunny commented Jul 3, 2025 

func shouldSendIssueChangeNotification(...) bool {
}

681ffa6

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 3, 2025
@wxiaoguang wxiaoguang merged commit 8cbec63 into go-gitea:main Jul 3, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.25.0 milestone Jul 3, 2025
@wxiaoguang wxiaoguang deleted the lunny/pending_comment_not_trigger_webhook branch July 3, 2025 02:35
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jul 3, 2025
@lunny @wxiaoguang @GiteaBot
Don't send trigger for a pending review's comment create/update/delete (
e4db1a5 
go-gitea#34928)

Fix go-gitea#18846 
Fix go-gitea#34924

---------

Co-authored-by: wxiaoguang <[email protected]>
@GiteaBot GiteaBot mentioned this pull request Jul 3, 2025
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Jul 3, 2025
wxiaoguang added a commit that referenced this pull request Jul 3, 2025
@GiteaBot @lunny @wxiaoguang
Don't send trigger for a pending review's comment create/update/delete (
9adf175 
#34928) (#34939)

Backport #34928 by lunny

Fix #18846 
Fix #34924

Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: wxiaoguang <[email protected]>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 4, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
b963fdf 
* giteaofficial/main:
  Fix http auth header parsing (go-gitea#34936)
  Don't send trigger for a pending review's comment create/update/delete (go-gitea#34928)
  Support getting last commit message using contents-ext API (go-gitea#34904)
  [skip ci] Updated translations via Crowdin
  Exclude devtest.ts from tailwindcss (go-gitea#34935)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

+1 more reviewer

@hiifong hiifong hiifong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created backport/v1.24 This PR should be backported to Gitea 1.24 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code type/bug

Projects

None yet

Milestone

1.25.0

Development

Successfully merging this pull request may close these issues.

Deleting comment in review triggers dicord webhook Do not track edits and deletions of pending review comments

5 participants

@lunny @wxiaoguang @delvh @hiifong @GiteaBot