Skip to content

Fix job status aggregation logic #35000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 17, 2025
Merged

Fix job status aggregation logic #35000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6277448
Fix job status aggregation logic
NorthRealm Jul 8, 2025
ef273f2
Merge branch 'main' into patch6-1
NorthRealm Jul 14, 2025
1b3d286
Merge branch 'main' into patch6-1
NorthRealm Jul 15, 2025
7811c5d
Merge branch 'main' into patch6-1
NorthRealm Jul 16, 2025
a819f13
Merge branch 'main' into patch6-1
NorthRealm Jul 16, 2025
82d1e8c
Merge branch 'main' into patch6-1
lunny Jul 17, 2025
e1442e7
Merge branch 'main' into patch6-1
NorthRealm Jul 17, 2025
3efa6bb
Merge branch 'main' into patch6-1
NorthRealm Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions models/actions/run_job.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,10 +187,10 @@ func AggregateJobStatus(jobs []*ActionRunJob) Status {
return StatusCancelled
case hasRunning:
return StatusRunning
case hasFailure:
return StatusFailure
case hasWaiting:
return StatusWaiting
case hasFailure:
return StatusFailure
case hasBlocked:
return StatusBlocked
default:
Expand Down
2 changes: 1 addition & 1 deletion models/actions/run_job_status_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ func TestAggregateJobStatus(t *testing.T) {
{[]Status{StatusFailure, StatusSuccess}, StatusFailure},
{[]Status{StatusFailure, StatusSkipped}, StatusFailure},
{[]Status{StatusFailure, StatusCancelled}, StatusCancelled},
{[]Status{StatusFailure, StatusWaiting}, StatusFailure},
{[]Status{StatusFailure, StatusWaiting}, StatusWaiting},
{[]Status{StatusFailure, StatusRunning}, StatusRunning},
{[]Status{StatusFailure, StatusBlocked}, StatusFailure},

Expand Down