Skip to content

Fix bug when displaying git user avatar in commits list #35006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2025
Merged

Fix bug when displaying git user avatar in commits list #35006

merged 1 commit into from
Jul 10, 2025

Conversation

@GiteaBot
Copy link
Collaborator

@GiteaBot GiteaBot commented Jul 8, 2025 •
edited by wxiaoguang
Loading

A quick fix for #34991

@GiteaBot GiteaBot added modifies/templates This PR modifies the template files type/bug labels Jul 8, 2025
@GiteaBot GiteaBot added this to the 1.24.3 milestone Jul 8, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 8, 2025
@GiteaBot GiteaBot requested review from delvh and lafriks July 8, 2025 22:49
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 8, 2025
wxiaoguang

This comment was marked as outdated.

Sign in to view

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 9, 2025
@lunny lunny closed this Jul 9, 2025
@lunny lunny removed this from the 1.24.3 milestone Jul 9, 2025
@wxiaoguang wxiaoguang reopened this Jul 9, 2025
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Jul 9, 2025

Use it as a quick fix.

1.25 will get proper fix.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Jul 9, 2025
@wxiaoguang wxiaoguang closed this Jul 9, 2025
@wxiaoguang wxiaoguang reopened this Jul 10, 2025
@wxiaoguang wxiaoguang mentioned this pull request Jul 10, 2025
Closed
25 tasks
@wxiaoguang wxiaoguang force-pushed the backport-35003-v1.24 branch from bc84f87 to 99a3208 Compare July 10, 2025 09:32
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jul 10, 2025
@wxiaoguang wxiaoguang changed the title Fix bug when displaying git user avatar in commits list (#35003) Fix bug when displaying git user avatar in commits list Jul 10, 2025
@wxiaoguang wxiaoguang force-pushed the backport-35003-v1.24 branch from 99a3208 to 877caae Compare July 10, 2025 09:38
@wxiaoguang wxiaoguang added this to the 1.24.3 milestone Jul 10, 2025
@lunny lunny merged commit 9f1baa7 into go-gitea:release/v1.24 Jul 10, 2025
26 checks passed
@lunny lunny mentioned this pull request Jul 10, 2025
Closed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lafriks lafriks lafriks approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh Awaiting requested review from delvh

Assignees

@lunny lunny

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/docs modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files type/bug

Projects

None yet

Milestone

1.24.3

Development

Successfully merging this pull request may close these issues.

4 participants

@GiteaBot @wxiaoguang @lafriks @lunny