Skip to content

Fix ListWorkflowRuns OpenAPI response model. #35026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 10, 2025
+5 −5
Merged

Fix ListWorkflowRuns OpenAPI response model. #35026

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8b537a4
Change the OpenAPI response of `ListWorkflowRuns` to `WorkflowRunsLis…
ScionOfDesign Jul 10, 2025
7a4d932
Made it so that required non-nullable values are either not present o…
ScionOfDesign Jul 10, 2025
e54d2ba
Fix linting and omit parent if there is none.
ScionOfDesign Jul 10, 2025
826ef86
Satisfy linter.
ScionOfDesign Jul 10, 2025
1a204a2
Switched to using `util.SliceNilAsEmpty(`.
ScionOfDesign Jul 10, 2025
0beced9
Re-added pre-allocation.
ScionOfDesign Jul 10, 2025
921cb46
Update models/repo/license.go
wxiaoguang Jul 10, 2025
3f7dbe6
Merge branch 'main' into fix-workflow-runs-openapi
wxiaoguang Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion models/repo/license.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ type RepoLicense struct { //revive:disable-line:exported
type RepoLicenseList []*RepoLicense //revive:disable-line:exported

func (rll RepoLicenseList) StringList() []string {
var licenses []string
licenses := make([]string, 0, len(rll))
for _, rl := range rll {
licenses = append(licenses, rl.License)
}
Expand Down
4 changes: 2 additions & 2 deletions modules/structs/repo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ type Repository struct {
Private bool `json:"private"`
Fork bool `json:"fork"`
Template bool `json:"template"`
Parent *Repository `json:"parent"`
Parent *Repository `json:"parent,omitempty"`
Mirror bool `json:"mirror"`
Size int `json:"size"`
Language string `json:"language"`
Expand Down Expand Up @@ -114,7 +114,7 @@ type Repository struct {
ObjectFormatName string `json:"object_format_name"`
// swagger:strfmt date-time
MirrorUpdated time.Time `json:"mirror_updated"`
RepoTransfer *RepoTransfer `json:"repo_transfer"`
RepoTransfer *RepoTransfer `json:"repo_transfer,omitempty"`
Topics []string `json:"topics"`
Licenses []string `json:"licenses"`
}
Expand Down
2 changes: 1 addition & 1 deletion routers/api/v1/repo/action.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -747,7 +747,7 @@ func (Action) ListWorkflowRuns(ctx *context.APIContext) {
// type: integer
// responses:
// "200":
// "$ref": "#/responses/ArtifactsList"
// "$ref": "#/responses/WorkflowRunsList"
// "400":
// "$ref": "#/responses/error"
// "404":
Expand Down
2 changes: 1 addition & 1 deletion templates/swagger/v1_json.tmpl
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.