Skip to content

Only hide dropzone when no files have been uploaded #35156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 26, 2025
Merged

Only hide dropzone when no files have been uploaded #35156

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
29d353f
Only hide dropzone when no files have been uploaded
bartvdbraak Jul 24, 2025
7e55d4d
Replace fragile selectors with direct options from Dropzone
bartvdbraak Jul 25, 2025
7f65e6f
Apply suggestion
wxiaoguang Jul 25, 2025
c606832
Apply suggestion
wxiaoguang Jul 25, 2025
0e949d4
Apply suggestion
wxiaoguang Jul 25, 2025
86e0932
Apply suggestion
wxiaoguang Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion web_src/js/features/repo-issue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,7 +542,14 @@ function initIssueTemplateCommentEditors(commentForm: HTMLFormElement) {
// deactivate all markdown editors
showElem(commentForm.querySelectorAll('.combo-editor-dropzone .form-field-real'));
hideElem(commentForm.querySelectorAll('.combo-editor-dropzone .combo-markdown-editor'));
hideElem(commentForm.querySelectorAll('.combo-editor-dropzone .form-field-dropzone'));
queryElems(commentForm, '.combo-editor-dropzone .form-field-dropzone', (dropzoneContainer) => {
const dropzoneEl = dropzoneContainer.closest<HTMLElement>('.combo-editor-dropzone')?.querySelector<HTMLElement>('.dropzone');
const dzInstance = dropzoneEl?.dropzone;

if (dzInstance && dzInstance.files.length === 0) {
hideElem(dropzoneContainer);
}
});

// activate this markdown editor
hideElem(fieldTextarea);
Expand Down