-
-
Notifications
You must be signed in to change notification settings - Fork 6k
Fix a bug where lfs gc never worked. #35198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
But is it right? Is the In the future, if a change in |
The test just demonstrate there is a bug in the INI package. |
Why not provide a correct test for real code? |
17e00d6 added a test for Get GC LFS configuration |
Fix #31113
After #22385 introduced LFS GC, it never worked due to a bug in the INI library: fields in structs embedded more than one level deep are not populated from the INI file.
This PR fixes the issue by replacing the multi-level embedded struct with a single-level struct for parsing the cron.gc_lfs configuration.
Added a new test for retrieving cron settings to demonstrate the bug in the INI package.