Skip to content

fix: remove duplicate IDs #35210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 18, 2025
Merged

fix: remove duplicate IDs #35210

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
32b4725
feat: support multi-line selection with URL parameters
kerwin612 Aug 4, 2025
d7ccf38
Update web_src/js/features/repo-code.ts
kerwin612 Aug 4, 2025
c63f1d2
Update web_src/js/features/repo-code.ts
kerwin612 Aug 4, 2025
886f546
clean code
kerwin612 Aug 9, 2025
4916e7f
Merge branch 'main' into feature/multi-line-selection-url
kerwin612 Aug 11, 2025
e5774b5
clean code
kerwin612 Aug 11, 2025
9ca5c42
Update repo-code.ts
kerwin612 Aug 11, 2025
d601ec5
Merge branch 'main' into feature/multi-line-selection-url
GiteaBot Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion templates/repo/view_file.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@
{{range $idx, $code := .FileContent}}
{{$line := Eval $idx "+" 1}}
<tr>
<td id="L{{$line}}" class="lines-num"><span id="L{{$line}}" data-line-number="{{$line}}"></span></td>
<td id="L{{$line}}" class="lines-num"><span data-line-number="{{$line}}"></span></td>
{{if $.EscapeStatus.Escaped}}
<td class="lines-escape">{{if (index $.LineEscapeStatus $idx).Escaped}}<button class="toggle-escape-button btn interact-bg" title="{{if (index $.LineEscapeStatus $idx).HasInvisible}}{{ctx.Locale.Tr "repo.invisible_runes_line"}} {{end}}{{if (index $.LineEscapeStatus $idx).HasAmbiguous}}{{ctx.Locale.Tr "repo.ambiguous_runes_line"}}{{end}}"></button>{{end}}</td>
{{end}}
Expand Down
15 changes: 13 additions & 2 deletions web_src/js/features/repo-code.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ function changeHash(hash: string) {
// it selects the code lines defined by range: `L1-L3` (3 lines) or `L2` (singe line)
function selectRange(range: string): Element {
for (const el of document.querySelectorAll('.code-view tr.active')) el.classList.remove('active');
const elLineNums = document.querySelectorAll(`.code-view td.lines-num span[data-line-number]`);
const elLineNums = document.querySelectorAll(`.code-view td.lines-num[id^="L"]`);

const refInNewIssue = document.querySelector('a.ref-in-new-issue');
const copyPermalink = document.querySelector('a.copy-line-permalink');
Expand Down Expand Up @@ -107,6 +107,17 @@ function showLineButton() {
}, {once: true});
},
});

// Handle menu button click manually
btn.addEventListener('click', (e) => {
e.stopPropagation();
const tippyInstance = btn._tippy;
if (tippyInstance?.state.isShown) {
tippyInstance.hide();
} else if (tippyInstance) {
tippyInstance.show();
}
});
}

export function initRepoCodeView() {
Expand All @@ -118,7 +129,7 @@ export function initRepoCodeView() {

// "file code view" and "blame" pages need this "line number button" feature
let selRangeStart: string;
addDelegatedEventListener(document, 'click', '.code-view .lines-num span', (el: HTMLElement, e: KeyboardEvent) => {
addDelegatedEventListener(document, 'click', '.code-view .lines-num', (el: HTMLElement, e: KeyboardEvent) => {
if (!selRangeStart || !e.shiftKey) {
selRangeStart = el.getAttribute('id');
selectRange(selRangeStart);
Expand Down