-
-
Notifications
You must be signed in to change notification settings - Fork 6k
Switch to pnpm #35274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+13,197
−14,451
Merged
Switch to pnpm #35274
Changes from 24 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
199c021
Switch to pnpm
techknowlogick c2fd022
add pnpm setup action
techknowlogick 357086b
Merge remote-tracking branch 'upstream/main' into pnpm
techknowlogick b25482f
use pnpm version from config file
techknowlogick 95609c8
update lock file
techknowlogick 71d5a30
fixup lint error
techknowlogick 9cb4747
add pnpm to docker build
techknowlogick e1e58b5
Merge branch 'main' into pnpm
techknowlogick 2bc8601
Update webpack.config.js
techknowlogick a5533ac
Merge branch 'main' into pnpm
techknowlogick b0a28f0
add pnpm to flake
techknowlogick 5b5092b
Merge remote-tracking branch 'upstream/main' into pnpm
techknowlogick c54c8cd
Merge branch 'main' into pnpm
techknowlogick 5dba206
Merge branch 'main' into pnpm
6543 4343eab
Merge branch 'main' into pnpm
techknowlogick e3e68ee
Update package.json
techknowlogick 8b18402
Merge remote-tracking branch 'upstream/main' into pnpm
techknowlogick 9a21be9
use published package for license checker fork
techknowlogick ad76d74
add note about installing pnpm if missing
techknowlogick ab34337
Merge branch 'main' into pnpm
techknowlogick bd06180
Merge branch 'main' into pnpm
techknowlogick add7099
Merge branch 'main' into pnpm
techknowlogick 454f467
Merge branch 'main' into pnpm
techknowlogick c0abec3
Merge branch 'main' into pnpm
techknowlogick 0d4b469
use separate package.json for tools
techknowlogick 287a1da
fix lint errors
techknowlogick ceb0111
add back comments to skip some lint rules
techknowlogick 41f8659
Merge branch 'main' into pnpm
techknowlogick File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
audit=false | ||
fund=false | ||
update-notifier=false | ||
package-lock=true | ||
save-exact=true | ||
lockfile-version=3 | ||
auto-install-peers=true | ||
dedupe-peer-dependents=false | ||
enable-pre-post-scripts=true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pnpm install
does not have a--no-save
option: https://pnpm.io/cli/install and it therefor errors:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently there is open issue pnpm/pnpm#1237 about it. I'm not sure how to solve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess what we should do is make a second
package.json
and lockfile inside thetools
directory that holds these dependencies. That way we avoid anypnpm install
failures related to those native modules on the main package.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I separated it out, and added cairo and pixman to the flake so that at least those who use nix can ensure they have the expected build deps. I'll have to add a mention of those two to the docs as turns out that prebuilt versions of canvas aren't available for at least my combination of devices and node versions.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think there might be some wasm-based svg-to-png solution somewhere which would work everywhere, but this is good enough for now.
Edit: Likely https://github.com/ssssota/svg2png-wasm