Remove unnecessary quote in language file to make crowdin work #35481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/refactoring
GiteaBot
added
the
lgtm/need 2
wxiaoguang
reviewed
Sep 14, 2025
| min_size_error = " must contain at least %s characters." | ||
| max_size_error = " must contain at most %s characters." | ||
| email_error = " is not a valid email address." | ||
| url_error = "\"%s\" is not a valid URL." |
There was a problem hiding this comment.
Wrong.
Please fully understand the problem first.
There was a problem hiding this comment.
It was converted according to the first comment here.
There was a problem hiding this comment.
No, it's wrong. INI package can't parse it. See the test cases
There was a problem hiding this comment.
The INI package is totally a shit.
|
Maybe we can add a linter tool for this. Or switch to a sane format like json or yaml. |
|
It needs to rewrite the INI package. |
|
replaced by #35489 |
|
I sent #35489 to convert to JSON format. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.