-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
fix attachment file size limit in server backend #35519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
a1012112796
wants to merge
14
commits into
go-gitea:main
Choose a base branch
from
a1012112796:zzc/dev/attach_size_limit
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+168
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix go-gitea#35512 Signed-off-by: a1012112796 <[email protected]>
CI fail is related:
Also, it's probably better to have a status 413 returned if the size is too large |
Signed-off-by: a1012112796 <[email protected]>
lunny
approved these changes
Sep 23, 2025
wxiaoguang
reviewed
Sep 23, 2025
wxiaoguang
reviewed
Sep 23, 2025
wxiaoguang
reviewed
Sep 23, 2025
last call @go-gitea/technical-oversight-committee |
6543
reviewed
Oct 6, 2025
Co-authored-by: 6543 <[email protected]> Signed-off-by: Lunny Xiao <[email protected]>
6543
reviewed
Oct 6, 2025
could push it in myselfe ... |
6543
approved these changes
Oct 7, 2025
wxiaoguang
requested changes
Oct 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the new changes are wrong.
header.Size
can't lie.
I try to write a prove of concept |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/v1.25
lgtm/blocked
A maintainer has reservations with the PR and thus it cannot be merged
modifies/api
This PR adds API routes or modifies them
modifies/go
Pull requests that update Go code
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #35512