Skip to content

Do not allow edit of due date for restricted users #35550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
+29 −2
Draft

Do not allow edit of due date for restricted users #35550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f91dff7
modules/setting: introduce restricted_user.go + AllowEditDueDate setting
t-h-i-s Sep 25, 2025
c945223
routers/web/repo.issue.go: prohibit set of due date for restricted us…
t-h-i-s Sep 25, 2025
793b45d
routers/api/v1/repo/issue.go: prohibit set of due date for restricted…
t-h-i-s Sep 25, 2025
63db354
routers/web/repo/issue.go: make due date read only restricted users i…
t-h-i-s Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions modules/setting/restricted_user.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// Copyright 2025 The Gitea Authors. All rights reserved.
// SPDX-License-Identifier: MIT

package setting

var RestrictedUser = struct {
AllowEditDueDate bool
}{}

func loadRestrictedUserFrom(rootCfg ConfigProvider) {
sec := rootCfg.Section("restricted_user")

RestrictedUser.AllowEditDueDate = sec.Key("ALLOW_EDIT_DUE_DATE").MustBool(false)
}
1 change: 1 addition & 0 deletions modules/setting/setting.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,7 @@ func LoadSettings() {

loadDBSetting(CfgProvider)
loadServiceFrom(CfgProvider)
loadRestrictedUserFrom(CfgProvider)
loadOAuth2ClientFrom(CfgProvider)
loadCacheFrom(CfgProvider)
loadSessionFrom(CfgProvider)
Expand Down
5 changes: 5 additions & 0 deletions routers/api/v1/repo/issue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,6 +845,11 @@ func EditIssue(ctx *context.APIContext) {

// Update or remove the deadline, only if set and allowed
if (form.Deadline != nil || form.RemoveDeadline != nil) && canWrite {
if ctx.Doer.IsRestricted && !setting.RestrictedUser.AllowEditDueDate {
ctx.APIError(http.StatusForbidden, "restricted users cannot modify due dates")
return
}

var deadlineUnix timeutil.TimeStamp

if form.RemoveDeadline == nil || !*form.RemoveDeadline {
Expand Down
6 changes: 6 additions & 0 deletions routers/web/repo/issue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import (
"code.gitea.io/gitea/modules/log"
"code.gitea.io/gitea/modules/markup/markdown"
"code.gitea.io/gitea/modules/optional"
"code.gitea.io/gitea/modules/setting"
api "code.gitea.io/gitea/modules/structs"
"code.gitea.io/gitea/modules/templates"
"code.gitea.io/gitea/modules/util"
Expand Down Expand Up @@ -397,6 +398,11 @@ func UpdateIssueDeadline(ctx *context.Context) {
return
}

if ctx.Doer.IsRestricted && !setting.RestrictedUser.AllowEditDueDate {
ctx.HTTPError(http.StatusForbidden, "", "restricted users cannot modify due dates")
return
}

deadlineUnix, _ := common.ParseDeadlineDateToEndOfDay(ctx.FormString("deadline"))
if err := issues_model.UpdateIssueDeadline(ctx, issue, deadlineUnix, ctx.Doer); err != nil {
ctx.HTTPError(http.StatusInternalServerError, "UpdateIssueDeadline", err.Error())
Expand Down
1 change: 1 addition & 0 deletions routers/web/repo/issue_view.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,6 +412,7 @@ func ViewIssue(ctx *context.Context) {
ctx.Data["SignInLink"] = setting.AppSubURL + "/user/login?redirect_to=" + url.QueryEscape(ctx.Data["Link"].(string))
ctx.Data["IsIssuePoster"] = ctx.IsSigned && issue.IsPoster(ctx.Doer.ID)
ctx.Data["HasIssuesOrPullsWritePermission"] = ctx.Repo.CanWriteIssuesOrPulls(issue.IsPull)
ctx.Data["AllowEditDueDate"] = ctx.Repo.CanWriteIssuesOrPulls(issue.IsPull) && !(ctx.Doer.IsRestricted && !setting.RestrictedUser.AllowEditDueDate)
ctx.Data["HasProjectsWritePermission"] = ctx.Repo.CanWrite(unit.TypeProjects)
ctx.Data["IsRepoAdmin"] = ctx.IsSigned && (ctx.Repo.IsAdmin() || ctx.Doer.IsAdmin)
ctx.Data["LockReasons"] = setting.Repository.Issue.LockReasons
Expand Down
4 changes: 2 additions & 2 deletions templates/repo/issue/sidebar/due_date.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
{{svg "octicon-calendar"}} {{DateUtils.AbsoluteLong .Issue.DeadlineUnix}}
</div>
<div class="flex-text-block">
{{if and .HasIssuesOrPullsWritePermission (not .Repository.IsArchived)}}
{{if and .AllowEditDueDate (not .Repository.IsArchived)}}
<a class="issue-due-edit muted" data-tooltip-content="{{ctx.Locale.Tr "repo.issues.due_date_form_edit"}}">{{svg "octicon-pencil"}}</a>
<a class="issue-due-remove muted" data-tooltip-content="{{ctx.Locale.Tr "repo.issues.due_date_form_remove"}}">{{svg "octicon-trash"}}</a>
{{end}}
Expand All @@ -17,7 +17,7 @@
{{ctx.Locale.Tr "repo.issues.due_date_not_set"}}
{{end}}

{{if and .HasIssuesOrPullsWritePermission (not .Repository.IsArchived)}}
{{if and .AllowEditDueDate (not .Repository.IsArchived)}}
<form class="ui fluid action input issue-due-form form-fetch-action tw-mt-2 {{if .Issue.DeadlineUnix}}tw-hidden{{end}}"
method="post" action="{{AppSubUrl}}/{{PathEscape .Repository.Owner.Name}}/{{PathEscape .Repository.Name}}/issues/{{.Issue.Index}}/deadline"
>
Expand Down