Skip to content

Fix code tag style problem and LFS view bug #35628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 11, 2025
Merged

Fix code tag style problem and LFS view bug #35628

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2bbb716
Update base.css
lutinglt Oct 11, 2025
ffb622f
fix
wxiaoguang Oct 11, 2025
4945c07
fix markup
wxiaoguang Oct 11, 2025
1edb5de
remove incorrect <code> tags
wxiaoguang Oct 11, 2025
6540596
fix lfs download link
wxiaoguang Oct 11, 2025
242a701
fine tune form help command block
wxiaoguang Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions web_src/css/base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,15 @@ samp,
font-size: 0.95em; /* compensate for monospace fonts being usually slightly larger */
}

/* there are many <code> blocks in non-markup(.markup code) / non-code-diff(code.code-inner) containers (for example: translation strings, etc),
so we need to make <code> have default global styles, ".markup code" has its own styles and doesn't conflict, but `.code-inner` is special.
TODO: in the future, we should use `div` instead of `code` for `.code-inner` because it is a container for highlighted code line */
code:not(.code-inner) {
padding: 1px 4px;
border-radius: var(--border-radius);
background-color: var(--color-label-bg);
}

b,
strong,
h1,
Expand Down Expand Up @@ -297,13 +306,6 @@ a.label,
text-decoration-line: none !important;
}

.help code {
padding: 1px 4px;
border-radius: var(--border-radius);
background-color: var(--color-label-bg);
color: var(--color-label-text);
}

.ui.search > .results {
background: var(--color-body);
border-color: var(--color-secondary);
Expand Down