Skip to content

Fix a missed return in OAuth2 (#35655) #35671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 15, 2025
Merged

Fix a missed return in OAuth2 (#35655) #35671

merged 2 commits into from
Oct 15, 2025

Conversation

@GiteaBot
Copy link
Collaborator

Backport #35655 by @lunny

@GiteaBot GiteaBot added modifies/go Pull requests that update Go code type/bug labels Oct 15, 2025
@GiteaBot GiteaBot added this to the 1.24.7 milestone Oct 15, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 15, 2025
@GiteaBot GiteaBot requested review from delvh and silverwind October 15, 2025 04:08
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 15, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 15, 2025
@lunny lunny enabled auto-merge (squash) October 15, 2025 06:58
@lunny lunny merged commit b854930 into go-gitea:release/v1.24 Oct 15, 2025
26 checks passed
@wxiaoguang wxiaoguang changed the title Fix a bug missed return (#35655) Fix a missed return in OAuth2 (#35655) Oct 26, 2025
@wxiaoguang wxiaoguang added the topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! label Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

@delvh delvh Awaiting requested review from delvh

+1 more reviewer

@Zettat123 Zettat123 Zettat123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lunny lunny

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! type/bug

Projects

None yet

Milestone

1.24.7

Development

Successfully merging this pull request may close these issues.

5 participants

@GiteaBot @lunny @silverwind @Zettat123 @wxiaoguang