fix(actions): use SSH_DOMAIN for server URL when app domain is different #35700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…domain When SSH_DOMAIN is configured to use a different hostname than the main AppURL domain, Gitea Actions should provide the SSH domain in the server_url context to ensure checkout actions connect to the correct SSH hostname. This fixes an issue where workflows would fail with 'Host key verification failed' because checkout actions were trying to connect to the wrong SSH hostname when SSH_DOMAIN was configured differently from the main domain. Fixes: Actions workflows failing when SSH_DOMAIN != main domain Before: server_url always used AppURL domain (e.g., git.example.com) After: server_url uses SSH_DOMAIN when different (e.g., git-ssh.example.com)
GiteaBot
added
the
lgtm/need 2
|
But Gitea/GitHub Actions doesn't use SSH if I remember correctly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SSH_DOMAIN is configured to use a different hostname than the main AppURL domain, Gitea Actions should provide the SSH domain in the server_url context to ensure checkout actions connect to the correct SSH hostname.
This fixes an issue where workflows would fail with 'Host key verification failed' because checkout actions were trying to connect to the wrong SSH hostname when SSH_DOMAIN was configured differently from the main domain.
Fixes: Actions workflows failing when SSH_DOMAIN != main domain
Before: server_url always used AppURL domain (e.g., git.example.com)
After: server_url uses SSH_DOMAIN when different (e.g., git-ssh.example.com)