-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Improve online runner check #35722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve online runner check #35722
Conversation
|
I actually missed a placeholder job log of all queued (waiting) jobs that contains the actual runner label. The advantage over could be run-list performance, on the other hand it is also nice to not need to go into the job list at all. |
Maybe we can add this warning to the job list later as well. |
8406d10 to
fb296a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check whether new changes look good
The left one: it is not a sentence, left is name, right is icon, two "block" elements. The right one: it is in a sentence "commit xxx pushed by yyy". So the texts need 0.25em gap. If you'd like to add gap for the icon, the layout needs to be |
Thank you! Now I understand this. Looks good to me. |

This PR moves "no online runner" warning to the runs list.
A job's
runs-onmay contain expressions likeruns-on: [self-hosted, "${{ inputs.chosen-os }}"]so the value ofruns-onmay be different in each run. We cannot check it through the workflow file.Screenshots
Before:
After:
This PR also splits
prepareWorkflowDispatchTemplatefunction into 2 functions:prepareWorkflowTemplateget and check all of the workflowsprepareWorkflowDispatchTemplateonly prepare workflow dispatch config forworkflow_dispatchworkflows.