Skip to content

Conversation

@Zettat123
Copy link
Contributor

@Zettat123 Zettat123 commented Oct 21, 2025

This PR moves "no online runner" warning to the runs list.

A job's runs-on may contain expressions like runs-on: [self-hosted, "${{ inputs.chosen-os }}"] so the value of runs-on may be different in each run. We cannot check it through the workflow file.

Screenshots

Before:

3d2a91746271d8b1f12c8f7d20eba550

After:

image

This PR also splits prepareWorkflowDispatchTemplate function into 2 functions:

  • prepareWorkflowTemplate get and check all of the workflows
  • prepareWorkflowDispatchTemplate only prepare workflow dispatch config for workflow_dispatch workflows.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 21, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Oct 21, 2025
@ChristopherHX ChristopherHX added the topic/gitea-actions related to the actions of Gitea label Oct 21, 2025
@ChristopherHX
Copy link
Contributor

I actually missed a placeholder job log of all queued (waiting) jobs that contains the actual runner label.

The advantage over could be run-list performance, on the other hand it is also nice to not need to go into the job list at all.

@Zettat123
Copy link
Contributor Author

I actually missed a placeholder job log of all queued (waiting) jobs that contains the actual runner label.

The advantage over could be run-list performance, on the other hand it is also nice to not need to go into the job list at all.

Maybe we can add this warning to the job list later as well.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 22, 2025
@lunny lunny added this to the 1.26.0 milestone Oct 22, 2025
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check whether new changes look good

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 24, 2025
@Zettat123
Copy link
Contributor Author

Please check whether new changes look good

Thanks for the change. I just have a small question: the distance between the two icons and the text looks different, is this as expected?

image

@wxiaoguang
Copy link
Contributor

Please check whether new changes look good

Thanks for the change. I just have a small question: the distance between the two icons and the text looks different, is this as expected?

inline means the space is for inline texts, 0.25em is like a normal space

block means the space is for block elements, 0.5em is for their space margins.

The left one: it is not a sentence, left is name, right is icon, two "block" elements.

The right one: it is in a sentence "commit xxx pushed by yyy". So the texts need 0.25em gap. If you'd like to add gap for the icon, the layout needs to be <flex block> <flex inline>commit xxx pushed by yyy</flex inline> <svg></flex block>. But I think it doesn't need to be that complex.

@Zettat123
Copy link
Contributor Author

Please check whether new changes look good

Thanks for the change. I just have a small question: the distance between the two icons and the text looks different, is this as expected?

inline means the space is for inline texts, 0.25em is like a normal space

block means the space is for block elements, 0.5em is for their space margins.

The left one: it is not a sentence, left is name, right is icon, two "block" elements.

The right one: it is in a sentence "commit xxx pushed by yyy". So the texts need 0.25em gap. If you'd like to add gap for the icon, the layout needs to be <flex block> <flex inline>commit xxx pushed by yyy</flex inline> <svg></flex block>. But I think it doesn't need to be that complex.

Thank you! Now I understand this. Looks good to me.

@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 24, 2025
@lunny lunny merged commit 0d740a6 into go-gitea:main Oct 24, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files topic/gitea-actions related to the actions of Gitea

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants