-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Introduce "config edit-ini" sub command to help maintaining INI config file #35735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
13185e6 to
63a5301
Compare
|
Maybe this is a good opportunity to restrict environment-based configuration to only specific sections. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as the only concern I have are flag name and semi-clear instructions, the latter of which can easily be reworded if someone will have questions about the behavior.
I don't have much better ideas for the flag name though the template part still feels wrong here but naming things always was hard :)
761c0e8 to
6802be3
Compare
|
Applied your suggestions and made new changes:
|
Ref: #32669. Helps addressing https://gitea.com/gitea/helm-chart/issues/356.
If you need to re-create the configuration file with only a subset of keys,
you can provide an INI template file and use the "--config-keep-keys" flag.
For example, if a helm chart needs to reset the settings and only keep SECRET_KEY,
it can use a template file like:
$ ./gitea config edit-ini --config app-old.ini --config-keep-keys app-template.ini --out app-new.ini