Skip to content

upgrade go mail #35752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 27, 2025
Merged

upgrade go mail #35752

merged 2 commits into from
Oct 27, 2025
+28 −33

Conversation

@lunny
Copy link
Member

@lunny lunny commented Oct 26, 2025 •
edited
Loading

backport #35748

@GiteaBot GiteaBot added this to the 1.24.7 milestone Oct 26, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 26, 2025
@lunny lunny removed this from the 1.24.7 milestone Oct 26, 2025
@silverwind
Copy link
Member

silverwind commented Oct 27, 2025 •
edited
Loading 

Error: models/asymkey/ssh_key_parse.go:211:7: SA1019: ssh.KeyAlgoDSA is deprecated: DSA is only supported at insecure key sizes, and was removed from major implementations. (staticcheck)

We probably missed another required backport for the 1.24 branch. Or maybe just // nolint:staticcheck it.

@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Oct 27, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 27, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 27, 2025
@lunny lunny merged commit ac69bf8 into go-gitea:release/v1.24 Oct 27, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Oct 27, 2025
@lunny lunny deleted the lunny/backport_35748_2 branch October 27, 2025 16:59
@lunny lunny removed this from the 1.26.0 milestone Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@silverwind silverwind silverwind approved these changes

+1 more reviewer

@Zettat123 Zettat123 Zettat123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/dependencies modifies/go Pull requests that update Go code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lunny @silverwind @Zettat123 @GiteaBot