-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Update JS dependencies #35759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update JS dependencies #35759
+445
−208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to https://pnpm.io/package_json#engines, pnpm does care about
So i guess I will revert this, given that some developers may run slightly older versions. |
|
So I think the best course forward is:
I updated |
wxiaoguang
approved these changes
Oct 28, 2025
lunny
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/dependencies
modifies/frontend
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updatesnow also supports updatingpackageManagerandengines, and I see no reason not to do that, so I think we can try keeping these updated as well. If something in the build breaks because of this, I will revert and excludepnpmfrom updating further, but as far as I understand, only corepack respects this field and pnpm itself does not care about it.