Skip to content

Conversation

@silverwind
Copy link
Member

Enable https://eslint.vuejs.org/rules/require-typed-ref and fix discovered issues.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 28, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 28, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 28, 2025
@wxiaoguang wxiaoguang merged commit fe25997 into go-gitea:main Oct 29, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Oct 29, 2025
@wxiaoguang wxiaoguang deleted the vue-require-typed-ref branch October 29, 2025 09:42
@silverwind
Copy link
Member Author

We should enable https://www.typescriptlang.org/tsconfig/#strictNullChecks in typescript which will make this rule obsolete. As I see it, the rule is therefor a temporary solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants