Fix actions rerun bug #35783
Merged
Fix actions rerun bug #35783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
wxiaoguang
approved these changes
Oct 29, 2025
GiteaBot
added
lgtm/need 1
|
A lot of changes are 1.26 only, so maybe you need to manually backport the fix |
Yes. I think the backport needs to be fixed manually. |
lunny
approved these changes
Oct 30, 2025
GiteaBot
added
lgtm/done
Zettat123
added a commit
to Zettat123/gitea
that referenced
this pull request
Oct 30, 2025
Related issues: go-gitea#35780, go-gitea#35782 Rerunning a job or a run is only allowed when the job is done and the run is done. Related PR: go-gitea#34970
mithileshgupta12
pushed a commit
to mithileshgupta12/gitea
that referenced
this pull request
Oct 30, 2025
Related issues: go-gitea#35780, go-gitea#35782 Rerunning a job or a run is only allowed when the job is done and the run is done. Related PR: go-gitea#34970
silverwind
pushed a commit
that referenced
this pull request
Oct 30, 2025
Backport #35783 Fix #35780, fix #35782 Rerunning a job or a run is only allowed when the job is done and the run is done. Related PR: #34970 https://github.com/go-gitea/gitea/blob/98ff7d077376db1225f266095788c6bd9414288a/routers/web/repo/actions/view.go#L239 We don't need to check run status again in `rerunJob` because the run status has been changed before `rerunJob`. --- In fact, the bug described in the above issues will not occur on the main branch. Because `getRunJobs` is called before updating the run. https://github.com/go-gitea/gitea/blob/98ff7d077376db1225f266095788c6bd9414288a/routers/web/repo/actions/view.go#L425-L435 So the run status that `rerunJob` checks is the old status. --------- Co-authored-by: wxiaoguang <[email protected]>
techknowlogick
pushed a commit
that referenced
this pull request
Nov 4, 2025
#35783 fixes an actions rerun bug. Due to this bug, some runs may be incorrectly marked as `StatusWaiting` even though all the jobs are in done status. These runs cannot be run or cancelled. This PR adds a new doctor command to fix the inconsistent run status. ``` gitea doctor check --run fix-actions-unfinished-run-status --fix ``` Thanks to @ChristopherHX for the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues: #35780, #35782
Rerunning a job or a run is only allowed when the job is done and the run is done.
Related PR: #34970
gitea/routers/web/repo/actions/view.go
Line 239 in 98ff7d0
We don't need to check run status again in
rerunJobbecause the run status has been changed beforererunJob.In fact, the bug described in the above issues will not occur on the main branch. Because
getRunJobsis called before updating the run.gitea/routers/web/repo/actions/view.go
Lines 425 to 435 in 98ff7d0
So the run status that
rerunJobchecks is the old status.