Fix actions rerun bug #35783

Zettat123 · 2025-10-29T21:27:23Z

Related issues: #35780, #35782

Rerunning a job or a run is only allowed when the job is done and the run is done.

Related PR: #34970

Line 239 in 98ff7d0

    
           resp.State.Run.CanRerun = run.Status.IsDone() && ctx.Repo.CanWrite(unit.TypeActions)

We don't need to check run status again in rerunJob because the run status has been changed before rerunJob.

In fact, the bug described in the above issues will not occur on the main branch. Because getRunJobs is called before updating the run.

gitea/routers/web/repo/actions/view.go

Lines 425 to 435 in 98ff7d0

    
           job, jobs := getRunJobs(ctx, runIndex, jobIndex) 
        
           if ctx.Written() { 
        
           	return 
        
           } 
        
           // reset run's start and stop time when it is done 
        
           if run.Status.IsDone() { 
        
           	run.PreviousDuration = run.Duration() 
        
           	run.Started = 0 
        
           	run.Stopped = 0 
        
           	run.Status = actions_model.StatusWaiting

So the run status that rerunJob checks is the old status.

wxiaoguang · 2025-10-29T23:24:03Z

A lot of changes are 1.26 only, so maybe you need to manually backport the fix

Zettat123 · 2025-10-29T23:28:42Z

A lot of changes are 1.26 only, so maybe you need to manually backport the fix

Yes. I think the backport needs to be fixed manually.

Related issues: go-gitea#35780, go-gitea#35782 Rerunning a job or a run is only allowed when the job is done and the run is done. Related PR: go-gitea#34970

Backport #35783 Fix #35780, fix #35782 Rerunning a job or a run is only allowed when the job is done and the run is done. Related PR: #34970 https://github.com/go-gitea/gitea/blob/98ff7d077376db1225f266095788c6bd9414288a/routers/web/repo/actions/view.go#L239 We don't need to check run status again in `rerunJob` because the run status has been changed before `rerunJob`. --- In fact, the bug described in the above issues will not occur on the main branch. Because `getRunJobs` is called before updating the run. https://github.com/go-gitea/gitea/blob/98ff7d077376db1225f266095788c6bd9414288a/routers/web/repo/actions/view.go#L425-L435 So the run status that `rerunJob` checks is the old status. --------- Co-authored-by: wxiaoguang <[email protected]>

@ChristopherHX

#35783 fixes an actions rerun bug. Due to this bug, some runs may be incorrectly marked as `StatusWaiting` even though all the jobs are in done status. These runs cannot be run or cancelled. This PR adds a new doctor command to fix the inconsistent run status. ``` gitea doctor check --run fix-actions-unfinished-run-status --fix ``` Thanks to @ChristopherHX for the test.

Backport #35840 #35783 fixes an actions rerun bug. Due to this bug, some runs may be incorrectly marked as `StatusWaiting` even though all the jobs are in done status. These runs cannot be run or cancelled. This PR adds a new doctor command to fix the inconsistent run status. ``` gitea doctor check --run fix-actions-unfinished-run-status --fix ```

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [go-gitea/gitea](https://github.com/go-gitea/gitea) | patch | `1.25.0` -> `1.25.1` | --- ### Release Notes <details> <summary>go-gitea/gitea (go-gitea/gitea)</summary> ### [`v1.25.1`](https://github.com/go-gitea/gitea/releases/tag/v1.25.1) [Compare Source](go-gitea/gitea@v1.25.0...v1.25.1) - BUGFIXES - Make ACME email optional ([#35849](go-gitea/gitea#35849)) [#35857](go-gitea/gitea#35857) - Add a doctor command to fix inconsistent run status ([#35840](go-gitea/gitea#35840)) ([#35845](go-gitea/gitea#35845)) - Remove wrong code ([#35846](go-gitea/gitea#35846)) - Fix viewed files number is not right if not all files loaded ([#35821](go-gitea/gitea#35821)) ([#35844](go-gitea/gitea#35844)) - Fix incorrect pull request counter ([#35819](go-gitea/gitea#35819)) ([#35841](go-gitea/gitea#35841)) - Upgrade go mail to 0.7.2 and fix the bug ([#35833](go-gitea/gitea#35833)) ([#35837](go-gitea/gitea#35837)) - Revert gomail to v0.7.0 to fix sending mail failed ([#35816](go-gitea/gitea#35816)) ([#35824](go-gitea/gitea#35824)) - Fix clone mixed bug ([#35810](go-gitea/gitea#35810)) ([#35822](go-gitea/gitea#35822)) - Fix cli "Before" handling ([#35797](go-gitea/gitea#35797)) ([#35808](go-gitea/gitea#35808)) - Improve and fix markup code preview rendering ([#35777](go-gitea/gitea#35777)) ([#35787](go-gitea/gitea#35787)) - Fix actions rerun bug ([#35783](go-gitea/gitea#35783)) ([#35784](go-gitea/gitea#35784)) - Fix actions schedule update issue ([#35767](go-gitea/gitea#35767)) ([#35774](go-gitea/gitea#35774)) - Fix circular spin animation direction ([#35785](go-gitea/gitea#35785)) ([#35823](go-gitea/gitea#35823)) - Fix file extension on gogs.png ([#35793](go-gitea/gitea#35793)) ([#35799](go-gitea/gitea#35799)) - Add pnpm to Snapcraft ([#35778](go-gitea/gitea#35778)) Instances on **[Gitea Cloud](https://cloud.gitea.com)** will be automatically upgraded to this version during the specified maintenance window. </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.com/gitea/helm-gitea/pulls/981 Reviewed-by: Markus Pesch <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>

fix rerun

2376eb3

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 29, 2025

github-actions bot added the modifies/go Pull requests that update Go code label Oct 29, 2025

Zettat123 added the type/bug label Oct 29, 2025

Zettat123 added 3 commits October 29, 2025 16:21

add TestActionsRerun

e00f342

fix check-backend

116e21f

update test

75b60fd

lunny added the backport/v1.25 label Oct 29, 2025

wxiaoguang approved these changes Oct 29, 2025

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 29, 2025

lunny approved these changes Oct 30, 2025

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 30, 2025

Merge branch 'main' into fix-actions-rerun

c1169d2

wxiaoguang enabled auto-merge (squash) October 30, 2025 00:56

wxiaoguang merged commit 3ab8ae5 into go-gitea:main Oct 30, 2025
26 checks passed

GiteaBot added this to the 1.26.0 milestone Oct 30, 2025

Zettat123 mentioned this pull request Oct 30, 2025

Fix actions rerun bug (#35783) #35784

Merged

Zettat123 added the backport/done All backports for this PR have been created label Oct 30, 2025

Zettat123 mentioned this pull request Nov 3, 2025

Add a doctor command to fix inconsistent run status #35840

Merged

Zettat123 mentioned this pull request Nov 4, 2025

Add a doctor command to fix inconsistent run status (#35840) #35845

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix actions rerun bug #35783

Fix actions rerun bug #35783

Zettat123 commented Oct 29, 2025 •

edited by wxiaoguang

Loading

Uh oh!

wxiaoguang commented Oct 29, 2025

Uh oh!

Zettat123 commented Oct 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	job, jobs := getRunJobs(ctx, runIndex, jobIndex)
	if ctx.Written() {
	return
	}

	// reset run's start and stop time when it is done
	if run.Status.IsDone() {
	run.PreviousDuration = run.Duration()
	run.Started = 0
	run.Stopped = 0
	run.Status = actions_model.StatusWaiting

Uh oh!

Fix actions rerun bug #35783

Fix actions rerun bug #35783

Conversation

Zettat123 commented Oct 29, 2025 • edited by wxiaoguang Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wxiaoguang commented Oct 29, 2025

Uh oh!

Zettat123 commented Oct 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Zettat123 commented Oct 29, 2025 •

edited by wxiaoguang

Loading