Skip to content

Improve and fix markup code preview rendering (#35777) #35787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2025
Merged

Improve and fix markup code preview rendering (#35777) #35787

merged 2 commits into from
Oct 30, 2025
+14 −9

Conversation

@GiteaBot
Copy link
Collaborator

Backport #35777 by @silverwind

  1. Add the color on the link to the referenced file, which is the more likely thing the user wants to click
  2. Use monospace font on the SHA
  3. Tweak text colors
  4. Change SHA link to go to the commit instead of the repo root with commit filter set
  5. Added the repo name to the file link text
  6. Fix broken line numbering rendering

The only major difference to GitHub is now the missing line numbers.

Before:

Screenshot 2025-10-29 at 19 09 59

After:

image

For comparison, GitHub rendering:

image

@silverwind @GiteaBot
Improve and fix markup code preview rendering (go-gitea#35777)
c59c91a 
1. Add the color on the link to the referenced file, which is the more
likely thing the user wants to click
2. Use monospace font on the SHA
3. Tweak text colors
4. Change SHA link to go to the commit instead of the repo root with
commit filter set
5. Added the repo name to the file link text
6. Fix broken line numbering rendering
@GiteaBot GiteaBot added modifies/frontend modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files type/bug labels Oct 30, 2025
@GiteaBot GiteaBot added this to the 1.25.1 milestone Oct 30, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 30, 2025
@GiteaBot GiteaBot requested review from lunny and wxiaoguang October 30, 2025 05:15
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 30, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 30, 2025
@silverwind silverwind mentioned this pull request Oct 30, 2025
Closed
@silverwind silverwind enabled auto-merge (squash) October 30, 2025 08:32
@silverwind silverwind merged commit e194d89 into go-gitea:release/v1.25 Oct 30, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@silverwind silverwind silverwind approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@lunny lunny Awaiting requested review from lunny

Assignees

@silverwind silverwind

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files type/bug

Projects

None yet

Milestone

1.25.1

Development

Successfully merging this pull request may close these issues.

3 participants

@GiteaBot @silverwind @wxiaoguang