-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Move Issue and PR buttons in navbar from left to right #35945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Seems a good change, my only worry is the the left side is a bit empty after this. Maybe later we could move those somewhere else and use the empty room as the page title. |
Custom links can be added on the left side, it may not be easy to move. |
|
I guess custom links could then be moved to the right side if we make use of the left side for title. |
|
But why are milestones placed on the left? For future features like Packages or a search box, should those also be moved to the right? |
|
Hmm, the left side of the header would then be empty if we move those as well. |
|
Place items strongly related to individual users on the right, and those weakly related on the left. User avatars should be on the right, and action buttons on the right should be user-related. Issues, PRs, and notifications follow the same logic—users typically want to view content related to themselves. However, milestones are clearly an exception. Although milestones are somewhat related to users, they are more relevant to the repository or organization. Those who need to view milestones are specialized users (e.g., product managers), not every user. Therefore, milestones should be placed on the left. This way, when users view content related to themselves, they don't need to check the left side but can focus solely on the right. |
|
Will this PR be merged? If not, I will close it. |
|
I can accept it as-is. Not sure about the others. |


octicon-belltoocticon-inboxto align with the icon used when there are no notifications.This style aligns more closely with GitHub's design.
before:



after:
mobile (320x738):
no notifications & icon height


before:
after: