add 'select/deselect all' buttons for custom events in webhooks#35980
add 'select/deselect all' buttons for custom events in webhooks#35980TimurRin wants to merge 2 commits intogo-gitea:mainfrom
Conversation
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/translation
modifies/templates
| all.forEach(i => { i.checked = false; }); | ||
| }); | ||
| })(); | ||
| </script> |
There was a problem hiding this comment.
- We need to move this code to
web_src/js/features/repo-settings.ts. We avoid inline scripts because they are problematic with CSP and also the linter does not lint them. - Use
for-ofloops instead offorEach, but the linter will also tell you that 😉.
There was a problem hiding this comment.
Isn't it better to place this code to web_src/js/features/comp/WebHookEditor.ts? There is already 'custom events' switch logic presented and webhooks are not bound to repos.
There was a problem hiding this comment.
Yes, that looks like a even better place.
| {{ctx.Locale.Tr "repo.settings.event_button_deselect_all"}} | ||
| </button> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
Please move it to line 97. It's more logical for it to be after the "Repository Events" header.
|
Definitely a useful feature, thanks. |
|
Maybe those buttons could even be moved to the right side of the header to save even more space, pseudo code: <div class="tw-flex tw-justify-between tw-gap-2">
<h2>Repository-Events</h2>
<div>...buttons</div>
</div> |
This header labels only for a group of checkboxes and may be misleading. I suggest to move them to the right side of the radio button. They will be shown only when 'Custom events' option is selected. 
|
4 participants
This PR adds
Select AllandDeselect Allbuttons to the 'Custom events' section of the webhook view.This is useful when you need select all events but one.