feat: add inline comments on commits #36398

jayantpranjal0 · 2026-01-17T19:15:56Z

Copilot

Pull request overview

This pull request adds inline comment functionality on commits, enabling users to add comments directly on commit diff lines similar to how comments work in pull request file reviews. This addresses issue #4898.

Changes:

Added new database models for commit comments and reactions with CRUD operations
Implemented handler routes for creating, updating, deleting commit comments and managing reactions
Extended frontend JavaScript to handle comment interactions on commit diffs using event delegation
Updated templates to conditionally render commit comment forms and context menus based on commit context

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 15 comments.

Show a summary per file

File	Description
models/git/commit_comment.go	New model for storing commit-level code comments
models/git/commit_comment_reaction.go	New model for reactions on commit comments
models/git/commit_comment_test.go	Unit tests for commit comment model operations
routers/web/repo/commit_comment.go	HTTP handlers for commit comment CRUD and reactions
routers/web/repo/commit.go	Integration of commit comments into commit diff view
routers/web/web.go	New routes for commit comment endpoints
services/gitdiff/gitdiff.go	Service layer for loading commit comments into diff structures
web_src/js/features/repo-legacy.ts	Initialize comment handlers globally for commit pages
web_src/js/features/repo-issue.ts	Updated event delegation to pointerdown for DOM stability
web_src/js/features/repo-issue-edit.ts	Enhanced edit/quote handlers with data-target support for detached menus
web_src/js/features/repo-diff.ts	Updated form submission to handle commit comment responses
templates/repo/issue/view_content/context_menu.tmpl	Context menu with commit-specific URLs and permissions
templates/repo/diff/section_unified.tmpl	Show add-comment buttons on commit diffs with permission checks
templates/repo/diff/section_split.tmpl	Show add-comment buttons on commit diffs with permission checks
templates/repo/diff/comments.tmpl	Render comments with commit-specific reaction and edit URLs
templates/repo/diff/comment_form.tmpl	Form action routing for commit vs PR contexts
templates/repo/diff/box.tmpl	New comment URL configuration for commit diffs

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

routers/web/repo/commit_comment.go

templates/repo/diff/comment_form.tmpl

routers/web/repo/commit_comment.go

models/git/commit_comment.go

models/git/commit_comment_reaction.go

routers/web/repo/commit_comment.go

templates/repo/diff/box.tmpl

routers/web/repo/commit_comment.go

Co-authored-by: Copilot <[email protected]> Signed-off-by: Jayant Pranjal <[email protected]>

Copilot

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

models/migrations/migrations.go

templates/repo/issue/view_content/context_menu.tmpl

routers/web/repo/commit_comment.go

models/git/commit_comment.go

models/migrations/v1_26/v326.go

routers/web/repo/commit_comment.go

web_src/js/features/repo-diff.ts

jayantpranjal0 · 2026-01-21T20:22:08Z

@lunny can you check out this PR??

silverwind · 2026-01-22T05:28:27Z

web_src/js/features/repo-legacy.ts

+    initRepoIssueCommentDelete();
+    initRepoIssueCodeCommentCancel();
+    initRepoIssueReferenceIssue();
+    initCompReactionSelector();


These 5 are all for the comment editor, right? If yes, put them into a new initRepoCodeComments and use it also to initialize the other comments editors.

wxiaoguang · 2026-01-22T06:06:36Z

Please answer the concerns in #4898 first

Add inline comments on commits #4898 (comment)

jayantpranjal0 · 2026-01-22T17:44:15Z

Hi, from my understanding the use of commit comments would be mostly for having file specific information only for specific commits.

jayantpranjal0 · 2026-01-22T17:45:21Z

Also, I am looking at issue: #24635. Can you please confirm if it is available to work upon as in if it is something that is planned to be brought in. I would be happy to work on it, and also if you could assign to me the issue, that would be great.

wxiaoguang · 2026-01-22T17:50:41Z

If you are interested in the bounty, you need to have a clear picture about the requirements of end users.
If you are the user who needs this feature, you need to have a clear use case for it.

Which one is your case? By either, you need to be familiar with the code base, fully understand the details and have a complete design.

jayantpranjal0 · 2026-01-22T17:53:29Z

I actually came here looking for bounty, but I have been getting familiar with the code with quite some time. I actually left a comment (#4898 (comment)) quite some time before for this

wxiaoguang · 2026-01-22T17:55:29Z

Please answer the concerns in #4898 first

* [Add inline comments on commits #4898 (comment)](https://github.com/go-gitea/gitea/issues/4898#issuecomment-3505622175)

So, why this feature is needed as of today? How end users would really use it?

jayantpranjal0 · 2026-01-22T18:00:10Z

From what I understand we have messages for commits when we push the code, but to also have some inline comments pointing to specific line, we can have this feature. Ig, the people who need this feature might have some better ideas, but lets say someone has something to say about some commit which has already been pushed as in reviews to some already existing or merged pr, this might be helpful. Or lets say someone has a repository with some educational content, they can point to specific lines with comments indicating use of specific parts of code

wxiaoguang · 2026-01-22T18:03:16Z

the people who need this feature might have some better ideas

Why not open an issue or a PR? If the repo gets new commits, how to find these "ideas" again?

someone has something to say about some commit which has already been pushed as in reviews to some already existing or merged pr

Why not directly comment in the related PR?

Or lets say someone has a repository with some educational content, they can point to specific lines with comments indicating use of specific parts of code

Why not write the "educational content" into code comments? If the author pushes some new commits, how to find the old comments?

jayantpranjal0 · 2026-01-22T18:07:13Z

Yeahh, I agree there are ways to do this over implementing a completely new feature.

jayantpranjal0 · 2026-01-22T18:08:07Z

To be completely honest I mostly came here looking for bounties

Copilot AI review requested due to automatic review settings January 17, 2026 19:15

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 17, 2026

algora-pbc bot added the 🙋 Bounty claim label Jan 17, 2026

algora-pbc bot mentioned this pull request Jan 17, 2026

Add inline comments on commits #4898

Open

github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/frontend labels Jan 17, 2026

jayantpranjal0 marked this pull request as draft January 17, 2026 19:16

Copilot started reviewing on behalf of jayantpranjal0 January 17, 2026 19:16 View session

Copilot AI reviewed Jan 17, 2026

View reviewed changes

feat: add inline comments on commits

47a3bc9

jayantpranjal0 force-pushed the commit-inline-comments branch from 0fe10b6 to 47a3bc9 Compare January 18, 2026 23:02

added migrations

9f24172

github-actions bot added the modifies/migrations label Jan 18, 2026

jayantpranjal0 marked this pull request as ready for review January 18, 2026 23:06

jayantpranjal0 and others added 6 commits January 19, 2026 04:37

Update routers/web/repo/commit_comment.go

640bb19

Co-authored-by: Copilot <[email protected]> Signed-off-by: Jayant Pranjal <[email protected]>

Update templates/repo/diff/comment_form.tmpl

7945e63

Co-authored-by: Copilot <[email protected]> Signed-off-by: Jayant Pranjal <[email protected]>

Merge branch 'main' into commit-inline-comments

355473e

fix linting errors

d854619

fix tests

cd78b87

fix int test

bb1c8e3

jayantpranjal0 marked this pull request as draft January 19, 2026 00:25

jayantpranjal0 added 2 commits January 22, 2026 01:18

fix quote reply for commit comments

fe27e8c

fix reference in new issue

e497ad6

jayantpranjal0 marked this pull request as ready for review January 21, 2026 19:54

jayantpranjal0 added 2 commits January 22, 2026 01:27

Merge remote-tracking branch 'origin/main' into commit-inline-comments

e633556

fix migration issues

9481a7a

jayantpranjal0 requested a review from Copilot January 21, 2026 20:10

Copilot started reviewing on behalf of jayantpranjal0 January 21, 2026 20:11 View session

fix linting

6c1e618

Copilot AI reviewed Jan 21, 2026

View reviewed changes

silverwind reviewed Jan 22, 2026

View reviewed changes

wxiaoguang marked this pull request as draft January 22, 2026 06:07

silverwind added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Jan 23, 2026

wxiaoguang added issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail and removed type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Jan 23, 2026

Uh oh!

feat: add inline comments on commits #36398

Are you sure you want to change the base?

feat: add inline comments on commits #36398

Uh oh!

Conversation

jayantpranjal0 commented Jan 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jayantpranjal0 commented Jan 21, 2026

Uh oh!

silverwind Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

wxiaoguang commented Jan 22, 2026

Uh oh!

jayantpranjal0 commented Jan 22, 2026

Uh oh!

jayantpranjal0 commented Jan 22, 2026

Uh oh!

wxiaoguang commented Jan 22, 2026

Uh oh!

jayantpranjal0 commented Jan 22, 2026

Uh oh!

wxiaoguang commented Jan 22, 2026

Uh oh!

jayantpranjal0 commented Jan 22, 2026

Uh oh!

wxiaoguang commented Jan 22, 2026

Uh oh!

jayantpranjal0 commented Jan 22, 2026

Uh oh!

jayantpranjal0 commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jayantpranjal0 commented Jan 22, 2026 •

edited

Loading