Skip to content

Add an interface objectpool for batch cat file object readers #36407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
lunny wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add an interface objectpool for batch cat file object readers #36407

lunny wants to merge 3 commits into from
+181 −120

Conversation

@lunny
Copy link
Member

@lunny lunny commented Jan 19, 2026

No description provided.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jan 19, 2026
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 19, 2026
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jan 19, 2026
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Jan 19, 2026

I think I have said clearly: #36313 (comment)

wxiaoguang
wxiaoguang requested changes Jan 29, 2026
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again: "object pool" can't be a right name, no matter which language you use.

  • Golang sync.Pool: A Pool is a set of temporary objects that may be individually saved and retrieved.

FIXMEs should be fixed as the highest priority.

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wxiaoguang wxiaoguang wxiaoguang requested changes

Assignees

No one assigned

Labels

lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged modifies/go Pull requests that update Go code type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lunny @wxiaoguang @GiteaBot