Fix bug to check whether user can update pull request branch or rebase branch #36465
+225
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
techknowlogick
approved these changes
Jan 27, 2026
GiteaBot
added
lgtm/need 1
lunny
changed the title
wxiaoguang
reviewed
Jan 29, 2026
wxiaoguang
requested changes
Jan 29, 2026
Contributor
There was a problem hiding this comment.
The test is not complete, there will be regressions.
- You need to assert that "user can push" before the branch protection. Otherwise, any readers use also pass the tests.
pushAllowed = pushAllowed || mergeAllowedMaintainermeans "allow maintainer edit" can by pass the branch protection?- if yes, clearly test the behavior
- if no, fix the bug
- The test code just duplicates with TestAPIPullUpdateByRebase2.
- TestAPIPullUpdateByRebase2 can be deleted, and carefully test the function in unit test
GiteaBot
added
lgtm/blocked
Member
Author
This has been checked and deeaece added some new test for that.
deeaece updated the logic, now the user will inherit the pull request creator's permission when he is a maintainer and allowing maintainer edit is enabled.
Removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking whether a user can update a pull request branch or perform an update via rebase, a maintainer should inherit the pull request author’s permissions if Allow maintainer edits is enabled.